Mercurial > cpython-lru_cache-weakref
comparison Python/modsupport.c @ 39994:798935e1295e 2.5
Forward-port of r52136: a review of overflow-detecting code.
* unified the way intobject, longobject and mystrtoul handle
values around -sys.maxint-1.
* in general, trying to entierely avoid overflows in any computation
involving signed ints or longs is extremely involved. Fixed a few
simple cases where a compiler might be too clever (but that's all
guesswork).
* more overflow checks against bad data in marshal.c.
* 2.5 specific: fixed a number of places that were still confusing int
and Py_ssize_t. Some of them could potentially have caused
"real-world" breakage.
* list.pop(x): fixing overflow issues on x was messy. I just reverted
to PyArg_ParseTuple("n"), which does the right thing. (An obscure
test was trying to give a Decimal to list.pop()... doesn't make
sense any more IMHO)
* trying to write a few tests...
| author | Armin Rigo <arigo@tunes.org> |
|---|---|
| date | Wed, 04 Oct 2006 11:44:06 +0000 |
| parents | 6ba402b60041 |
| children | afa0ef379186 |
comparison
equal
deleted
inserted
replaced
| 39993:4eb286e931a9 | 39994:798935e1295e |
|---|---|
| 419 if (m > PY_SSIZE_T_MAX) { | 419 if (m > PY_SSIZE_T_MAX) { |
| 420 PyErr_SetString(PyExc_OverflowError, | 420 PyErr_SetString(PyExc_OverflowError, |
| 421 "string too long for Python string"); | 421 "string too long for Python string"); |
| 422 return NULL; | 422 return NULL; |
| 423 } | 423 } |
| 424 n = (int)m; | 424 n = (Py_ssize_t)m; |
| 425 } | 425 } |
| 426 v = PyString_FromStringAndSize(str, n); | 426 v = PyString_FromStringAndSize(str, n); |
| 427 } | 427 } |
| 428 return v; | 428 return v; |
| 429 } | 429 } |
