Mercurial > cpython-lru_cache-weakref
comparison Python/sysmodule.c @ 39994:798935e1295e 2.5
Forward-port of r52136: a review of overflow-detecting code.
* unified the way intobject, longobject and mystrtoul handle
values around -sys.maxint-1.
* in general, trying to entierely avoid overflows in any computation
involving signed ints or longs is extremely involved. Fixed a few
simple cases where a compiler might be too clever (but that's all
guesswork).
* more overflow checks against bad data in marshal.c.
* 2.5 specific: fixed a number of places that were still confusing int
and Py_ssize_t. Some of them could potentially have caused
"real-world" breakage.
* list.pop(x): fixing overflow issues on x was messy. I just reverted
to PyArg_ParseTuple("n"), which does the right thing. (An obscure
test was trying to give a Decimal to list.pop()... doesn't make
sense any more IMHO)
* trying to write a few tests...
| author | Armin Rigo <arigo@tunes.org> |
|---|---|
| date | Wed, 04 Oct 2006 11:44:06 +0000 |
| parents | 6ba402b60041 |
| children | c58d1b969843 |
comparison
equal
deleted
inserted
replaced
| 39993:4eb286e931a9 | 39994:798935e1295e |
|---|---|
| 1223 return NULL; | 1223 return NULL; |
| 1224 for (i = 0; ; i++) { | 1224 for (i = 0; ; i++) { |
| 1225 p = strchr(path, delim); | 1225 p = strchr(path, delim); |
| 1226 if (p == NULL) | 1226 if (p == NULL) |
| 1227 p = strchr(path, '\0'); /* End of string */ | 1227 p = strchr(path, '\0'); /* End of string */ |
| 1228 w = PyString_FromStringAndSize(path, (int) (p - path)); | 1228 w = PyString_FromStringAndSize(path, (Py_ssize_t) (p - path)); |
| 1229 if (w == NULL) { | 1229 if (w == NULL) { |
| 1230 Py_DECREF(v); | 1230 Py_DECREF(v); |
| 1231 return NULL; | 1231 return NULL; |
| 1232 } | 1232 } |
| 1233 PyList_SetItem(v, i, w); | 1233 PyList_SetItem(v, i, w); |
