Mercurial > cpython-lru_cache-weakref
comparison Objects/enumobject.c @ 35999:9541369b0dca legacy-trunk
Add const to several API functions that take char *.
In C++, it's an error to pass a string literal to a char* function
without a const_cast(). Rather than require every C++ extension
module to put a cast around string literals, fix the API to state the
const-ness.
I focused on parts of the API where people usually pass literals:
PyArg_ParseTuple() and friends, Py_BuildValue(), PyMethodDef, the type
slots, etc. Predictably, there were a large set of functions that
needed to be fixed as a result of these changes. The most pervasive
change was to make the keyword args list passed to
PyArg_ParseTupleAndKewords() to be a const char *kwlist[].
One cast was required as a result of the changes: A type object
mallocs the memory for its tp_doc slot and later frees it.
PyTypeObject says that tp_doc is const char *; but if the type was
created by type_new(), we know it is safe to cast to char *.
| author | Jeremy Hylton <jeremy@alum.mit.edu> |
|---|---|
| date | Sat, 10 Dec 2005 18:50:16 +0000 |
| parents | e22334b1da67 |
| children | 0eb6ef92c56e |
comparison
equal
deleted
inserted
replaced
| 35998:96d1fa36964d | 35999:9541369b0dca |
|---|---|
| 14 static PyObject * | 14 static PyObject * |
| 15 enum_new(PyTypeObject *type, PyObject *args, PyObject *kwds) | 15 enum_new(PyTypeObject *type, PyObject *args, PyObject *kwds) |
| 16 { | 16 { |
| 17 enumobject *en; | 17 enumobject *en; |
| 18 PyObject *seq = NULL; | 18 PyObject *seq = NULL; |
| 19 static char *kwlist[] = {"sequence", 0}; | 19 static const char *kwlist[] = {"sequence", 0}; |
| 20 | 20 |
| 21 if (!PyArg_ParseTupleAndKeywords(args, kwds, "O:enumerate", kwlist, | 21 if (!PyArg_ParseTupleAndKeywords(args, kwds, "O:enumerate", kwlist, |
| 22 &seq)) | 22 &seq)) |
| 23 return NULL; | 23 return NULL; |
| 24 | 24 |
