Mercurial > cpython-lru_cache-weakref
diff Lib/test/test_subprocess.py @ 59723:00daa8b736cc
* Fix a refleak when a preexec_fn was supplied (preexec_fn_args_tuple was not
being defref'ed).
* Fixes another potential refleak of a reference to the gc
module in the unlikely odd case where gc module isenabled or disable calls
fail.
* Adds a unittest for the above case to verify behavior and lack of leaks.
| author | Gregory P. Smith <greg@mad-scientist.com> |
|---|---|
| date | Fri, 19 Mar 2010 16:53:08 +0000 |
| parents | 768722b2ae0a |
| children | bb2ca1b63321 |
line wrap: on
line diff
--- a/Lib/test/test_subprocess.py Fri Mar 19 14:40:31 2010 +0000 +++ b/Lib/test/test_subprocess.py Fri Mar 19 16:53:08 2010 +0000 @@ -9,6 +9,10 @@ import time import re import sysconfig +try: + import gc +except ImportError: + gc = None mswindows = (sys.platform == "win32") @@ -650,6 +654,44 @@ self.fail("Exception raised by preexec_fn did not make it " "to the parent process.") + @unittest.skipUnless(gc, "Requires a gc module.") + def test_preexec_gc_module_failure(self): + # This tests the code that disables garbage collection if the child + # process will execute any Python. + def raise_runtime_error(): + raise RuntimeError("this shouldn't escape") + enabled = gc.isenabled() + orig_gc_disable = gc.disable + orig_gc_isenabled = gc.isenabled + try: + gc.disable() + self.assertFalse(gc.isenabled()) + subprocess.call([sys.executable, '-c', ''], + preexec_fn=lambda: None) + self.assertFalse(gc.isenabled(), + "Popen enabled gc when it shouldn't.") + + gc.enable() + self.assertTrue(gc.isenabled()) + subprocess.call([sys.executable, '-c', ''], + preexec_fn=lambda: None) + self.assertTrue(gc.isenabled(), "Popen left gc disabled.") + + gc.disable = raise_runtime_error + self.assertRaises(RuntimeError, subprocess.Popen, + [sys.executable, '-c', ''], + preexec_fn=lambda: None) + + del gc.isenabled # force an AttributeError + self.assertRaises(AttributeError, subprocess.Popen, + [sys.executable, '-c', ''], + preexec_fn=lambda: None) + finally: + gc.disable = orig_gc_disable + gc.isenabled = orig_gc_isenabled + if not enabled: + gc.disable() + def test_args_string(self): # args is a string fd, fname = mkstemp()