Mercurial > cpython-lru_cache-weakref

diff Python/sysmodule.c @ 84786:01597384531f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Issue #15905: Fix theoretical buffer overflow in handling of sys.argv[0], prefix and exec_prefix if the operation system does not obey MAXPATHLEN.
author Christian Heimes <christian@cheimes.de>
date Mon, 22 Jul 2013 12:54:21 +0200
parents 1da78c7d382b dca92e8a011a
children fc718c177ee6
line wrap: on
line diff
--- a/Python/sysmodule.c	Mon Jul 22 10:38:04 2013 +0200
+++ b/Python/sysmodule.c	Mon Jul 22 12:54:21 2013 +0200
@@ -1854,10 +1854,11 @@
             if (q == NULL)
                 argv0 = link; /* argv0 without path */
             else {
-                /* Must make a copy */
-                wcscpy(argv0copy, argv0);
+                /* Must make a copy, argv0copy has room for 2 * MAXPATHLEN */
+                wcsncpy(argv0copy, argv0, MAXPATHLEN);
                 q = wcsrchr(argv0copy, SEP);
-                wcscpy(q+1, link);
+                wcsncpy(q+1, link, MAXPATHLEN);
+                q[MAXPATHLEN + 1] = L'\0';
                 argv0 = argv0copy;
             }
         }