Mercurial > cpython-lru_cache-weakref
diff Python/pystate.c @ 39830:0bac40e4d0c6 legacy-trunk
Forward-port of rev. 51857:
Building with HP's cc on HP-UX turned up a couple of problems.
_PyGILState_NoteThreadState was declared as static inconsistently.
Make it static as it's not necessary outside of this module.
Some tests failed because errno was reset to 0. (I think the tests
that failed were at least: test_fcntl and test_mailbox).
Ensure that errno doesn't change after a call to Py_END_ALLOW_THREADS.
This only affected debug builds.
| author | Georg Brandl <georg@python.org> |
|---|---|
| date | Mon, 11 Sep 2006 09:38:35 +0000 |
| parents | de9e1a5dca93 |
| children | cab056903b3d |
line wrap: on
line diff
--- a/Python/pystate.c Mon Sep 11 04:32:57 2006 +0000 +++ b/Python/pystate.c Mon Sep 11 09:38:35 2006 +0000 @@ -309,9 +309,14 @@ */ #if defined(Py_DEBUG) && defined(WITH_THREAD) if (newts) { + /* This can be called from PyEval_RestoreThread(). Similar + to it, we need to ensure errno doesn't change. + */ + int err = errno; PyThreadState *check = PyGILState_GetThisThreadState(); if (check && check->interp == newts->interp && check != newts) Py_FatalError("Invalid thread state for this thread"); + errno = err; } #endif return oldts; @@ -504,7 +509,7 @@ it so it doesn't try to create another thread state for the thread (this is a better fix for SF bug #1010677 than the first one attempted). */ -void +static void _PyGILState_NoteThreadState(PyThreadState* tstate) { /* If autoTLSkey is 0, this must be the very first threadstate created