Mercurial > cpython-lru_cache-weakref
diff Modules/arraymodule.c @ 79529:152d85b2da3a 3.3
Issue #16096: Fix several occurrences of potential signed integer overflow. Thanks Serhiy Storchaka.
| author | Mark Dickinson <mdickinson@enthought.com> |
|---|---|
| date | Sat, 06 Oct 2012 18:04:49 +0100 |
| parents | 7d82a60850fd |
| children | 757cc49ced54 d2127cdec10e |
line wrap: on
line diff
--- a/Modules/arraymodule.c Sat Oct 06 18:45:47 2012 +0300 +++ b/Modules/arraymodule.c Sat Oct 06 18:04:49 2012 +0100 @@ -483,11 +483,11 @@ return NULL; } - nbytes = size * descr->itemsize; /* Check for overflow */ - if (nbytes / descr->itemsize != (size_t)size) { + if (size > PY_SSIZE_T_MAX / descr->itemsize) { return PyErr_NoMemory(); } + nbytes = size * descr->itemsize; op = (arrayobject *) type->tp_alloc(type, 0); if (op == NULL) { return NULL; @@ -1251,11 +1251,15 @@ if (!PyArg_ParseTuple(args, "On:fromfile", &f, &n)) return NULL; - nbytes = n * itemsize; - if (nbytes < 0 || nbytes/itemsize != n) { + if (n < 0) { + PyErr_SetString(PyExc_ValueError, "negative count"); + return NULL; + } + if (n > PY_SSIZE_T_MAX / itemsize) { PyErr_NoMemory(); return NULL; } + nbytes = n * itemsize; b = _PyObject_CallMethodId(f, &PyId_read, "n", nbytes); if (b == NULL)
