Mercurial > cpython-lru_cache-weakref
diff Objects/stringobject.c @ 52408:1afb365f2448 legacy-trunk
Issue #532631: Add paranoid check to avoid potential buffer overflow
on systems with sizeof(int) > 4.
| author | Mark Dickinson <dickinsm@gmail.com> |
|---|---|
| date | Sun, 29 Mar 2009 16:17:16 +0000 |
| parents | 019815bc37ea |
| children | 6947bc3dd433 |
line wrap: on
line diff
--- a/Objects/stringobject.c Sun Mar 29 14:37:51 2009 +0000 +++ b/Objects/stringobject.c Sun Mar 29 16:17:16 2009 +0000 @@ -4344,6 +4344,15 @@ } if (prec < 0) prec = 6; + /* make sure that the decimal representation of precision really does + need at most 10 digits: platforms with sizeof(int) == 8 exist! */ + if (prec > 0x7fffffffL) { + PyErr_SetString(PyExc_OverflowError, + "outrageously large precision " + "for formatted float"); + return -1; + } + if (type == 'f' && fabs(x) >= 1e50) type = 'g'; /* Worst case length calc to ensure no buffer overrun: @@ -4372,7 +4381,7 @@ PyOS_snprintf(fmt, sizeof(fmt), "%%%s.%d%c", (flags&F_ALT) ? "#" : "", prec, type); - PyOS_ascii_formatd(buf, buflen, fmt, x); + PyOS_ascii_formatd(buf, buflen, fmt, x); return (int)strlen(buf); }