Mercurial > cpython-lru_cache-weakref

diff Python/bltinmodule.c @ 8661:30fbf18af29e legacy-trunk

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Small changes to map() and filter(): (1) If a sequence S is shorter than len(S) indicated, don't fail -- just use the shorter size. (I.e, len(S) is just a hint.) (2) Implement the special case map(None, S) as list(S) -- it's faster.
author Guido van Rossum <guido@python.org>
date Fri, 10 Jul 1998 17:37:30 +0000
parents 97dc6aa532e7
children 83c8adaa084f
line wrap: on
line diff
--- a/Python/bltinmodule.c	Fri Jul 10 16:22:44 1998 +0000
+++ b/Python/bltinmodule.c	Fri Jul 10 17:37:30 1998 +0000
@@ -190,8 +190,6 @@
 		int ok;
 
 		if ((item = (*sqf->sq_item)(seq, i)) == NULL) {
-			if (i < len)
-				goto Fail_1;
 			if (PyErr_ExceptionMatches(PyExc_IndexError)) {
 				PyErr_Clear();
 				break;
@@ -784,6 +782,11 @@
 	func = PyTuple_GetItem(args, 0);
 	n--;
 
+	if (func == Py_None && n == 1) {
+		/* map(None, S) is the same as list(S). */
+		return PySequence_List(PyTuple_GetItem(args, 1));
+	}
+
 	if ((seqs = PyMem_NEW(sequence, n)) == NULL) {
 		PyErr_NoMemory();
 		goto Fail_2;
@@ -820,7 +823,6 @@
 	if ((result = (PyObject *) PyList_New(len)) == NULL)
 		goto Fail_2;
 
-	/* XXX Special case map(None, single_list) could be more efficient */
 	for (i = 0; ; ++i) {
 		PyObject *alist, *item=NULL, *value;
 		int any = 0;
@@ -840,8 +842,6 @@
 			else {
 				item = (*sqp->sqf->sq_item)(sqp->seq, i);
 				if (item == NULL) {
-					if (i < sqp->len)
-						goto Fail_0;
 					if (PyErr_ExceptionMatches(
 						PyExc_IndexError))
 					{
@@ -897,6 +897,9 @@
 		}
 	}
 
+	if (i < len && PyList_SetSlice(result, i, len, NULL) < 0)
+		goto Fail_1;
+
 	PyMem_DEL(seqs);
 	return result;