Mercurial > cpython-lru_cache-weakref
diff Python/pystate.c @ 33706:4981ba54f43d legacy-trunk
_PyGILState_Init(), PyGILState_Ensure(): Since PyThread_set_key_value()
can fail, check its return value, and die if it does fail.
_PyGILState_Init(): Assert that the thread doesn't already have an
association for autoTLSkey. If it does, PyThread_set_key_value() will
ignore the attempt to (re)set the association, which the code clearly
doesn't want.
| author | Tim Peters <tim.peters@gmail.com> |
|---|---|
| date | Sat, 09 Oct 2004 22:47:13 +0000 |
| parents | 0c26db381673 |
| children | 664b18aa6fc1 |
line wrap: on
line diff
--- a/Python/pystate.c Sat Oct 09 22:33:09 2004 +0000 +++ b/Python/pystate.c Sat Oct 09 22:47:13 2004 +0000 @@ -395,7 +395,9 @@ autoTLSkey = PyThread_create_key(); autoInterpreterState = i; /* Now stash the thread state for this thread in TLS */ - PyThread_set_key_value(autoTLSkey, (void *)t); + assert(PyThread_get_key_value(autoTLSkey) == NULL); + if (PyThread_set_key_value(autoTLSkey, (void *)t) < 0) + Py_FatalError("Couldn't create autoTLSkey mapping"); assert(t->gilstate_counter == 0); /* must be a new thread state */ t->gilstate_counter = 1; } @@ -434,7 +436,8 @@ tcur = PyThreadState_New(autoInterpreterState); if (tcur == NULL) Py_FatalError("Couldn't create thread-state for new thread"); - PyThread_set_key_value(autoTLSkey, (void *)tcur); + if (PyThread_set_key_value(autoTLSkey, (void *)tcur) < 0) + Py_FatalError("Couldn't create autoTLSkey mapping"); current = 0; /* new thread state is never current */ } else