diff setup.py @ 55065:56a276396e15 3.1

Merged revisions 73788 via svnmerge from svn+ssh://pythondev@svn.python.org/python/branches/py3k ........ r73788 | amaury.forgeotdarc | 2009-07-03 01:08:45 +0200 (ven., 03 juil. 2009) | 6 lines #4601: 'make install' did not set the permissions on library directories, only root could start IDLE for example. Beware that os.path.walk does not translate as is to os.walk! the former uses a callback to call on each dir, the latter is a generator... ........
author Amaury Forgeot d'Arc <amauryfa@gmail.com>
date Thu, 02 Jul 2009 23:57:11 +0000
parents 997ef68bfa15
children 5c8b2238a2f5 59c66ade3c26
line wrap: on
line diff
--- a/setup.py	Thu Jul 02 22:02:15 2009 +0000
+++ b/setup.py	Thu Jul 02 23:57:11 2009 +0000
@@ -1605,12 +1605,11 @@
 
     def set_dir_modes(self, dirname, mode):
         if not self.is_chmod_supported(): return
-        os.walk(dirname, self.set_dir_modes_visitor, mode)
-
-    def set_dir_modes_visitor(self, mode, dirname, names):
-        if os.path.islink(dirname): return
-        log.info("changing mode of %s to %o", dirname, mode)
-        if not self.dry_run: os.chmod(dirname, mode)
+        for dirpath, dirnames, fnames in os.walk(dirname):
+            if os.path.islink(dirpath):
+                continue
+            log.info("changing mode of %s to %o", dirpath, mode)
+            if not self.dry_run: os.chmod(dirpath, mode)
 
     def is_chmod_supported(self):
         return hasattr(os, 'chmod')