Mercurial > cpython-lru_cache-weakref

diff Python/exceptions.c @ 14013:6c7fa523726f legacy-trunk

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
SyntaxError__str__(): Fix two memory problems discovered by Insure. First, the allocated buffer was never freed after using it to create the PyString object. Second, it was possible that have_filename would be false (meaning that filename was not a PyString object), but that the code would still try to PyString_GET_SIZE() it.
author Barry Warsaw <barry@python.org>
date Wed, 16 Aug 2000 19:43:17 +0000
parents d8069efcd76e
children e8301612e7d8
line wrap: on
line diff
--- a/Python/exceptions.c	Wed Aug 16 19:02:06 2000 +0000
+++ b/Python/exceptions.c	Wed Aug 16 19:43:17 2000 +0000
@@ -775,18 +775,20 @@
 	int have_lineno = 0;
 	char *buffer = NULL;
 
-	if (filename = PyObject_GetAttrString(self, "filename"))
+	if ((filename = PyObject_GetAttrString(self, "filename")) != NULL)
 	    have_filename = PyString_Check(filename);
 	else
 	    PyErr_Clear();
-	if (lineno = PyObject_GetAttrString(self, "lineno"))
+
+	if ((lineno = PyObject_GetAttrString(self, "lineno")) != NULL)
 	    have_lineno = PyInt_Check(lineno);
 	else
 	    PyErr_Clear();
 
 	if (have_filename || have_lineno) {
-	    int bufsize = (PyString_GET_SIZE(str) + 64 +
-			   PyString_GET_SIZE(filename));
+	    int bufsize = PyString_GET_SIZE(str) + 64;
+	    if (have_filename)
+		bufsize += PyString_GET_SIZE(filename);
 
 	    buffer = PyMem_Malloc(bufsize);
 	    if (buffer != NULL) {
@@ -803,7 +805,10 @@
 		    sprintf(buffer, "%s (line %d)",
 			    PyString_AS_STRING(str),
 			    PyInt_AsLong(lineno));
+
 		result = PyString_FromString(buffer);
+		PyMem_FREE(buffer);
+
 		if (result == NULL)
 		    result = str;
 		else