Mercurial > cpython-lru_cache-weakref

diff Python/getargs.c @ 45986:72dc16e80179

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add XXX comments for whoever cleans up getargs.c :)
author Georg Brandl <georg@python.org>
date Fri, 21 Mar 2008 20:46:11 +0000
parents 8c3c5b4eef55
children 7c99cedc3e54
line wrap: on
line diff
--- a/Python/getargs.c	Fri Mar 21 19:42:31 2008 +0000
+++ b/Python/getargs.c	Fri Mar 21 20:46:11 2008 +0000
@@ -823,6 +823,9 @@
 			}
 			else
 				return converterr("string", arg, msgbuf, bufsize);
+			/* XXX(gb): this test is completely wrong -- p is a
+			 * byte string while arg is a Unicode. I *think* it should
+			 * check against the size of uarg... */
 			if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
 				return converterr("string without null bytes",
 						  arg, msgbuf, bufsize);
@@ -898,6 +901,7 @@
 				}
 				format++;
 			}
+			/* XXX(gb): same comment as for 's' applies here... */
 			else if (*p != NULL &&
 				 (Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
 				return converterr(