diff Python/modsupport.c @ 18908:79c676f9b34a legacy-trunk

This patch turns the Python API mismatch notice into a standard Python warning which can be catched by means of the Python warning framework. It also adds two new APIs which hopefully make it easier for Python to switch to buffer overflow safe [v]snprintf() APIs for error reporting et al. The two new APIs are PyOS_snprintf() and PyOS_vsnprintf() and work just like the standard ones in many C libs. On platforms which have snprintf(), the native APIs are used, on all other an emulation with snprintf() tries to do its best.
author Marc-André Lemburg <mal@egenix.com>
date Tue, 31 Jul 2001 13:24:44 +0000
parents d5811af8acf3
children 360cece76123
line wrap: on
line diff
--- a/Python/modsupport.c	Tue Jul 31 11:11:38 2001 +0000
+++ b/Python/modsupport.c	Tue Jul 31 13:24:44 2001 +0000
@@ -26,8 +26,8 @@
 */
 
 static char api_version_warning[] =
-"WARNING: Python C API version mismatch for module %s:\n\
-  This Python has API version %d, module %s has version %d.\n";
+"Python C API version mismatch for module %.100s:\
+ This Python has API version %d, module %.100s has version %d.";
 
 PyObject *
 Py_InitModule4(char *name, PyMethodDef *methods, char *doc,
@@ -37,9 +37,15 @@
 	PyMethodDef *ml;
 	if (!Py_IsInitialized())
 	    Py_FatalError("Interpreter not initialized (version mismatch?)");
-	if (module_api_version != PYTHON_API_VERSION)
-		fprintf(stderr, api_version_warning,
-			name, PYTHON_API_VERSION, name, module_api_version);
+	if (module_api_version != PYTHON_API_VERSION) {
+		char message[512];
+		PyOS_snprintf(message, sizeof(message), 
+			      api_version_warning, name, 
+			      PYTHON_API_VERSION, name, 
+			      module_api_version);
+		if (PyErr_Warn(PyExc_RuntimeWarning, message)) 
+			return NULL;
+	}
 	if (_Py_PackageContext != NULL) {
 		char *p = strrchr(_Py_PackageContext, '.');
 		if (p != NULL && strcmp(name, p+1) == 0) {