Mercurial > cpython-lru_cache-weakref
diff Modules/_cursesmodule.c @ 35999:9541369b0dca legacy-trunk
Add const to several API functions that take char *.
In C++, it's an error to pass a string literal to a char* function
without a const_cast(). Rather than require every C++ extension
module to put a cast around string literals, fix the API to state the
const-ness.
I focused on parts of the API where people usually pass literals:
PyArg_ParseTuple() and friends, Py_BuildValue(), PyMethodDef, the type
slots, etc. Predictably, there were a large set of functions that
needed to be fixed as a result of these changes. The most pervasive
change was to make the keyword args list passed to
PyArg_ParseTupleAndKewords() to be a const char *kwlist[].
One cast was required as a result of the changes: A type object
mallocs the memory for its tp_doc slot and later frees it.
PyTypeObject says that tp_doc is const char *; but if the type was
created by type_new(), we know it is safe to cast to char *.
| author | Jeremy Hylton <jeremy@alum.mit.edu> |
|---|---|
| date | Sat, 10 Dec 2005 18:50:16 +0000 |
| parents | 98179c8281cd |
| children | 3c030edff985 |
line wrap: on
line diff
--- a/Modules/_cursesmodule.c Sat Dec 10 17:44:27 2005 +0000 +++ b/Modules/_cursesmodule.c Sat Dec 10 18:50:16 2005 +0000 @@ -1886,10 +1886,10 @@ int err; char* termstr = NULL; - static char *kwlist[] = {"term", "fd", NULL}; + static const char *kwlist[] = {"term", "fd", NULL}; if (!PyArg_ParseTupleAndKeywords( - args,keywds,"|zi:setupterm",kwlist,&termstr,&fd)) { + args, keywds, "|zi:setupterm", kwlist, &termstr, &fd)) { return NULL; }
