Mercurial > cpython-lru_cache-weakref
diff Python/modsupport.c @ 44772:afa0ef379186 legacy-trunk
#1782: don't leak in error case in PyModule_AddXxxConstant. Patch by Hrvoje Nikšić.
| author | Georg Brandl <georg@python.org> |
|---|---|
| date | Sat, 19 Jan 2008 18:02:46 +0000 |
| parents | 6ba402b60041 |
| children | 4fe192d48960 |
line wrap: on
line diff
--- a/Python/modsupport.c Sat Jan 19 17:38:53 2008 +0000 +++ b/Python/modsupport.c Sat Jan 19 18:02:46 2008 +0000 @@ -621,11 +621,23 @@ int PyModule_AddIntConstant(PyObject *m, const char *name, long value) { - return PyModule_AddObject(m, name, PyInt_FromLong(value)); + PyObject *o = PyInt_FromLong(value); + if (!o) + return -1; + if (PyModule_AddObject(m, name, o) == 0) + return 0; + Py_DECREF(o); + return -1; } int PyModule_AddStringConstant(PyObject *m, const char *name, const char *value) { - return PyModule_AddObject(m, name, PyString_FromString(value)); + PyObject *o = PyString_FromString(value); + if (!o) + return -1; + if (PyModule_AddObject(m, name, o) == 0) + return 0; + Py_DECREF(o); + return -1; }