diff Modules/socketmodule.c @ 43300:b355d2dba9b6

merge this from trunk: r58067 | gregory.p.smith | 2007-09-09 16:36:46 -0700 (Sun, 09 Sep 2007) | 22 lin es Change socket.error to inherit from IOError rather than being a stand alone class. This addresses the primary concern in http://bugs.python.org/issue1706815 python-dev discussion here: http://mail.python.org/pipermail/python-dev/2007-July/073749.html I chose IOError rather than EnvironmentError as the base class since socket objects are often used as transparent duck typed file objects in code already prepared to deal with IOError exceptions. also a minor fix: urllib2 - fix a couple places where IOError was raised rather than URLError. for better or worse, URLError already inherits from IOError so this won't break any existing code. test_urllib2net - replace bad ftp urls.
author Gregory P. Smith <greg@mad-scientist.com>
date Sun, 09 Sep 2007 23:55:55 +0000
parents 9220931e4741
children 4e57c36f6d2e
line wrap: on
line diff
--- a/Modules/socketmodule.c	Sun Sep 09 20:17:22 2007 +0000
+++ b/Modules/socketmodule.c	Sun Sep 09 23:55:55 2007 +0000
@@ -4035,7 +4035,8 @@
 	if (m == NULL)
 		return;
 
-	socket_error = PyErr_NewException("socket.error", NULL, NULL);
+	socket_error = PyErr_NewException("socket.error",
+					  PyExc_IOError, NULL);
 	if (socket_error == NULL)
 		return;
         PySocketModuleAPI.error = socket_error;