Mercurial > cpython-lru_cache-weakref
diff Objects/classobject.c @ 41782:bee8d01ef42c
Add a format specifier %R to PyUnicode_FromFormat(), which embeds
the result of a call to PyObject_Repr() into the string. This makes
it possible to simplify many repr implementations.
PyUnicode_FromFormat() uses two steps to create the final string: A first
pass through the format string determines the size of the final string and
a second pass creates the string. To avoid calling PyObject_Repr() twice
for each %R specifier, PyObject_Repr() is called during the size
calculation step and the results are stored in an array (whose size is
determined at the start by counting %R specifiers).
| author | Walter Dörwald <walter@livinglogic.de> |
|---|---|
| date | Sat, 19 May 2007 21:49:49 +0000 |
| parents | b29d71d43c80 |
| children | cd125fe83051 |
line wrap: on
line diff
--- a/Objects/classobject.c Fri May 18 22:12:08 2007 +0000 +++ b/Objects/classobject.c Sat May 19 21:49:49 2007 +0000 @@ -261,11 +261,9 @@ result = PyUnicode_FromFormat("<unbound method %s.%s>", sklassname, sfuncname); else { - result = PyUnicode_FromFormat("<bound method %s.%s of ", - sklassname, sfuncname); - /* XXX Shouldn't use repr() here! */ - PyUnicode_AppendAndDel(&result, PyObject_Repr(self)); - PyUnicode_AppendAndDel(&result, PyUnicode_FromString(">")); + /* XXX Shouldn't use repr()/%R here! */ + result = PyUnicode_FromFormat("<bound method %s.%s of %R>", + sklassname, sfuncname, self); } Py_XDECREF(funcname); Py_XDECREF(klassname);