Mercurial > cpython-lru_cache-weakref
diff Python/bltinmodule.c @ 83315:cc59c215f19e
properly lookup the __round__ special method (closes #17722)
| author | Benjamin Peterson <benjamin@python.org> |
|---|---|
| date | Sat, 13 Apr 2013 17:19:01 -0400 |
| parents | 504eed5a82a3 |
| children | 6db3741e59be |
line wrap: on
line diff
--- a/Python/bltinmodule.c Sat Apr 13 22:46:33 2013 +0200 +++ b/Python/bltinmodule.c Sat Apr 13 17:19:01 2013 -0400 @@ -1810,10 +1810,10 @@ static PyObject * builtin_round(PyObject *self, PyObject *args, PyObject *kwds) { - static PyObject *round_str = NULL; PyObject *ndigits = NULL; static char *kwlist[] = {"number", "ndigits", 0}; - PyObject *number, *round; + PyObject *number, *round, *result; + _Py_IDENTIFIER(__round__); if (!PyArg_ParseTupleAndKeywords(args, kwds, "O|O:round", kwlist, &number, &ndigits)) @@ -1824,24 +1824,21 @@ return NULL; } - if (round_str == NULL) { - round_str = PyUnicode_InternFromString("__round__"); - if (round_str == NULL) - return NULL; - } - - round = _PyType_Lookup(Py_TYPE(number), round_str); + round = _PyObject_LookupSpecial(number, &PyId___round__); if (round == NULL) { - PyErr_Format(PyExc_TypeError, - "type %.100s doesn't define __round__ method", - Py_TYPE(number)->tp_name); + if (!PyErr_Occurred()) + PyErr_Format(PyExc_TypeError, + "type %.100s doesn't define __round__ method", + Py_TYPE(number)->tp_name); return NULL; } if (ndigits == NULL) - return PyObject_CallFunction(round, "O", number); + result = PyObject_CallFunctionObjArgs(round, NULL); else - return PyObject_CallFunction(round, "OO", number, ndigits); + result = PyObject_CallFunctionObjArgs(round, ndigits, NULL); + Py_DECREF(round); + return result; } PyDoc_STRVAR(round_doc,
