diff Lib/test/test_sys.py @ 42013:cd125fe83051

Make identifiers str (not str8) objects throughout. This affects the parser, various object implementations, and all places that put identifiers into C string literals. In testing, a number of crashes occurred as code would fail when the recursion limit was reached (such as the Unicode interning dictionary having key/value pairs where key is not value). To solve these, I added an overflowed flag, which allows for 50 more recursions after the limit was reached and the exception was raised, and a recursion_critical flag, which indicates that recursion absolutely must be allowed, i.e. that a certain call must not cause a stack overflow exception. There are still some places where both str and str8 are accepted as identifiers; these should eventually be removed.
author Martin v. Löwis <martin@v.loewis.de>
date Sun, 10 Jun 2007 09:51:05 +0000
parents 9d02a4adf574
children 81930eaae715
line wrap: on
line diff
--- a/Lib/test/test_sys.py	Sat Jun 09 16:13:23 2007 +0000
+++ b/Lib/test/test_sys.py	Sun Jun 10 09:51:05 2007 +0000
@@ -321,12 +321,6 @@
 
         self.assertRaises(TypeError, sys.intern, S("abc"))
 
-        # It's still safe to pass these strings to routines that
-        # call intern internally, e.g. PyObject_SetAttr().
-        s = S("abc")
-        setattr(s, s, s)
-        self.assertEqual(getattr(s, s), s)
-
         s = "never interned as unicode before"
         self.assert_(sys.intern(s) is s)
         s2 = s.swapcase().swapcase()
@@ -338,6 +332,12 @@
 
         self.assertRaises(TypeError, sys.intern, U("abc"))
 
+        # It's still safe to pass these strings to routines that
+        # call intern internally, e.g. PyObject_SetAttr().
+        s = U("abc")
+        setattr(s, s, s)
+        self.assertEqual(getattr(s, s), s)
+
 
 def test_main():
     test.test_support.run_unittest(SysModuleTest)