Mercurial > cpython-lru_cache-weakref
diff Python/import.c @ 76826:d6324941b739
Issue #14583: Fix importlib bug when a package's __init__.py would first import one of its modules then raise an error.
| author | Antoine Pitrou <solipsis@pitrou.net> |
|---|---|
| date | Mon, 07 May 2012 21:41:59 +0200 |
| parents | 49306ceaf91f |
| children | 840cb46d0395 |
line wrap: on
line diff
--- a/Python/import.c Mon May 07 17:25:14 2012 +0100 +++ b/Python/import.c Mon May 07 21:41:59 2012 +0200 @@ -1633,19 +1633,20 @@ goto error_with_unlock; } + if (PyUnicode_GET_LENGTH(PyTuple_GET_ITEM(partition, 1)) == 0) { + /* No dot in module name, simple exit */ + Py_DECREF(partition); + final_mod = mod; + Py_INCREF(mod); + goto exit_with_unlock; + } + front = PyTuple_GET_ITEM(partition, 0); Py_INCREF(front); Py_DECREF(partition); if (level == 0) { - final_mod = PyDict_GetItem(interp->modules, front); - if (final_mod == NULL) { - PyErr_Format(PyExc_KeyError, - "%R not in sys.modules as expected", front); - } - else { - Py_INCREF(final_mod); - } + final_mod = PyObject_CallFunctionObjArgs(builtins_import, front, NULL); Py_DECREF(front); } else { @@ -1682,6 +1683,8 @@ fromlist, builtins_import, NULL); } + + exit_with_unlock: error_with_unlock: #ifdef WITH_THREAD if (_PyImport_ReleaseLock() < 0) {
