diff Lib/subprocess.py @ 62401:da558461d9a9 legacy-trunk

Revert r60115 This revision introduced quoting for strings containing | based on a misunderstanding of the commonly used quoting rules used on Windows. | is interpreted by cmd.exe, not by the MS C runtime argv initializer. It only needs to be quoted if it is part of an argument passed through cmd.exe. See issue1300, issue7839, and issue8972.
author Jean-Paul Calderone <exarkun@divmod.com>
date Fri, 18 Jun 2010 20:00:17 +0000
parents e6bfe93b65bb
children 354546846c29
line wrap: on
line diff
--- a/Lib/subprocess.py	Thu Jun 17 20:30:56 2010 +0000
+++ b/Lib/subprocess.py	Fri Jun 18 20:00:17 2010 +0000
@@ -548,8 +548,8 @@
 
     2) A string surrounded by double quotation marks is
        interpreted as a single argument, regardless of white space
-       or pipe characters contained within.  A quoted string can be
-       embedded in an argument.
+       contained within.  A quoted string can be embedded in an
+       argument.
 
     3) A double quotation mark preceded by a backslash is
        interpreted as a literal double quotation mark.
@@ -577,7 +577,7 @@
         if result:
             result.append(' ')
 
-        needquote = (" " in arg) or ("\t" in arg) or ("|" in arg) or not arg
+        needquote = (" " in arg) or ("\t" in arg) or not arg
         if needquote:
             result.append('"')