Mercurial > cpython-lru_cache-weakref
diff Python/getargs.c @ 20716:dcf769c12d8b legacy-trunk
vgetargskeywords: Removed one of the mysterious PyErr_Clear() calls.
The "need" for this was probably removed by an earlier patch that stopped
the loop right before it from passing NULL to a dict lookup routine.
I still haven't convinced myself that the next loop is correct, so am
leaving the next mysterious PyErr_Clear() call in for now.
| author | Tim Peters <tim.peters@gmail.com> |
|---|---|
| date | Sat, 27 Oct 2001 05:30:17 +0000 |
| parents | 5e6f8187bd48 |
| children | 84715d52d954 |
line wrap: on
line diff
--- a/Python/getargs.c Sat Oct 27 05:07:41 2001 +0000 +++ b/Python/getargs.c Sat Oct 27 05:30:17 2001 +0000 @@ -1099,18 +1099,9 @@ } } } - /* XXX The loop just above didn't used to break when hitting the - end of kwlist, so could pass NULL on to PyMapping_HasKeyString, - which sets a "NULL argument to internal routine" error then. - However, the comment below doesn't give any clues about which - 'error string' it's talking about, so darned hard to say whether - the PyErr_Clear() still serves a purpose. - */ - PyErr_Clear(); /* I'm not which Py functions set the error string */ - + /* required arguments missing from args can be supplied by keyword arguments */ - len = nargs; if (keywords && nargs < min) { for (i = nargs; i < min; i++) {