diff Objects/moduleobject.c @ 65231:e2aa3b1d08bc

prefer clearing global objects to obscure module.__dict__ bugs #10068
author Benjamin Peterson <benjamin@python.org>
date Tue, 12 Oct 2010 22:57:59 +0000
parents ee765a67c0b1
children 62b61abd02b8
line wrap: on
line diff
--- a/Objects/moduleobject.c	Tue Oct 12 22:42:37 2010 +0000
+++ b/Objects/moduleobject.c	Tue Oct 12 22:57:59 2010 +0000
@@ -335,10 +335,7 @@
     if (m->md_def && m->md_def->m_free)
         m->md_def->m_free(m);
     if (m->md_dict != NULL) {
-        /* If we are the only ones holding a reference, we can clear
-           the dictionary. */
-        if (Py_REFCNT(m->md_dict) == 1)
-            _PyModule_Clear((PyObject *)m);
+        _PyModule_Clear((PyObject *)m);
         Py_DECREF(m->md_dict);
     }
     if (m->md_state != NULL)