Mercurial > cpython-lru_cache-weakref

diff Modules/mathmodule.c @ 46516:ec48490b969a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Merged revisions 62420-62421,62423-62424 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r62420 | mark.dickinson | 2008-04-20 20:30:05 +0200 (Sun, 20 Apr 2008) | 3 lines Even more fixes for alpha Tru64, this time for the phase and polar methods. ........ r62421 | mark.dickinson | 2008-04-20 22:38:48 +0200 (Sun, 20 Apr 2008) | 2 lines Add test for tanh(-0.) == -0. on IEEE 754 systems ........ r62423 | amaury.forgeotdarc | 2008-04-20 23:02:21 +0200 (Sun, 20 Apr 2008) | 3 lines Correct an apparent refleak in test_pkgutil: zipimport._zip_directory_cache contains info for all processed zip files, even when they are no longer used. ........ r62424 | mark.dickinson | 2008-04-20 23:39:04 +0200 (Sun, 20 Apr 2008) | 4 lines math.atan2 is misbehaving on Windows; this patch should fix the problem in the same way that the cmath.phase problems were fixed. ........
author Christian Heimes <christian@cheimes.de>
date Mon, 21 Apr 2008 13:08:03 +0000
parents 63965327b3ef
children 3f2117d3271f
line wrap: on
line diff
--- a/Modules/mathmodule.c	Mon Apr 21 11:59:36 2008 +0000
+++ b/Modules/mathmodule.c	Mon Apr 21 13:08:03 2008 +0000
@@ -96,6 +96,42 @@
 }
 
 /*
+   wrapper for atan2 that deals directly with special cases before
+   delegating to the platform libm for the remaining cases.  This
+   is necessary to get consistent behaviour across platforms.
+   Windows, FreeBSD and alpha Tru64 are amongst platforms that don't
+   always follow C99.
+*/
+
+static double
+m_atan2(double y, double x)
+{
+	if (Py_IS_NAN(x) || Py_IS_NAN(y))
+		return Py_NAN;
+	if (Py_IS_INFINITY(y)) {
+		if (Py_IS_INFINITY(x)) {
+			if (copysign(1., x) == 1.)
+				/* atan2(+-inf, +inf) == +-pi/4 */
+				return copysign(0.25*Py_MATH_PI, y);
+			else
+				/* atan2(+-inf, -inf) == +-pi*3/4 */
+				return copysign(0.75*Py_MATH_PI, y);
+		}
+		/* atan2(+-inf, x) == +-pi/2 for finite x */
+		return copysign(0.5*Py_MATH_PI, y);
+	}
+	if (Py_IS_INFINITY(x) || y == 0.) {
+		if (copysign(1., x) == 1.)
+			/* atan2(+-y, +inf) = atan2(+-0, +x) = +-0. */
+			return copysign(0., y);
+		else
+			/* atan2(+-y, -inf) = atan2(+-0., -x) = +-pi. */
+			return copysign(Py_MATH_PI, y);
+	}
+	return atan2(y, x);
+}
+
+/*
    math_1 is used to wrap a libm function f that takes a double
    arguments and returns a double.
 
@@ -250,7 +286,7 @@
       "asinh(x)\n\nReturn the hyperbolic arc sine (measured in radians) of x.")
 FUNC1(atan, atan, 0,
       "atan(x)\n\nReturn the arc tangent (measured in radians) of x.")
-FUNC2(atan2, atan2,
+FUNC2(atan2, m_atan2,
       "atan2(y, x)\n\nReturn the arc tangent (measured in radians) of y/x.\n"
       "Unlike atan(y/x), the signs of both x and y are considered.")
 FUNC1(atanh, atanh, 0,