Mercurial > cpython-lru_cache-weakref
diff Modules/_tkinter.c @ 38067:efeebc8770e5 2.4
Work around deadlock risk.
| author | Martin v. Löwis <martin@v.loewis.de> |
|---|---|
| date | Mon, 01 May 2006 06:29:06 +0000 |
| parents | b16e504413c3 |
| children | 129ab846a71f |
line wrap: on
line diff
--- a/Modules/_tkinter.c Sun Apr 30 21:26:41 2006 +0000 +++ b/Modules/_tkinter.c Mon May 01 06:29:06 2006 +0000 @@ -2609,20 +2609,32 @@ static PyObject * Tkapp_TkInit(PyObject *self, PyObject *args) { + static int has_failed; Tcl_Interp *interp = Tkapp_Interp(self); Tk_Window main_window; const char * _tk_exists = NULL; - PyObject *res = NULL; int err; main_window = Tk_MainWindow(interp); + /* In all current versions of Tk (including 8.4.13), Tk_Init + deadlocks on the second call when the first call failed. + To avoid the deadlock, we just refuse the second call through + a static variable. */ + if (has_failed) { + PyErr_SetString(Tkinter_TclError, + "Calling Tk_Init again after a previous call failed might deadlock"); + return NULL; + } + /* We want to guard against calling Tk_Init() multiple times */ CHECK_TCL_APPARTMENT; ENTER_TCL err = Tcl_Eval(Tkapp_Interp(self), "info exists tk_version"); ENTER_OVERLAP if (err == TCL_ERROR) { - res = Tkinter_Error(self); + /* This sets an exception, but we cannot return right + away because we need to exit the overlap first. */ + Tkinter_Error(self); } else { _tk_exists = Tkapp_Result(self); } @@ -2633,6 +2645,7 @@ if (_tk_exists == NULL || strcmp(_tk_exists, "1") != 0) { if (Tk_Init(interp) == TCL_ERROR) { PyErr_SetString(Tkinter_TclError, Tcl_GetStringResult(Tkapp_Interp(self))); + has_failed = 1; return NULL; } }
