diff Python/getargs.c @ 67342:f78e7db1d5e8

Issue #8651: PyArg_Parse*() functions raise an OverflowError if the file doesn't have PY_SSIZE_T_CLEAN define and the size doesn't fit in an int (length bigger than 2^31-1).
author Victor Stinner <victor.stinner@haypocalc.com>
date Tue, 04 Jan 2011 02:07:34 +0000
parents 379029714e24
children a7d15df7d67d
line wrap: on
line diff
--- a/Python/getargs.c	Tue Jan 04 00:29:35 2011 +0000
+++ b/Python/getargs.c	Tue Jan 04 02:07:34 2011 +0000
@@ -597,7 +597,17 @@
 #define FETCH_SIZE      int *q=NULL;Py_ssize_t *q2=NULL;\
     if (flags & FLAG_SIZE_T) q2=va_arg(*p_va, Py_ssize_t*); \
     else q=va_arg(*p_va, int*);
-#define STORE_SIZE(s)   if (flags & FLAG_SIZE_T) *q2=s; else *q=s;
+#define STORE_SIZE(s)   \
+    if (flags & FLAG_SIZE_T) \
+        *q2=s; \
+    else { \
+        if (INT_MAX < s) { \
+            PyErr_SetString(PyExc_OverflowError, \
+                "size does not fit in an int"); \
+            return converterr("", arg, msgbuf, bufsize); \
+        } \
+        *q=s; \
+    }
 #define BUFFER_LEN      ((flags & FLAG_SIZE_T) ? *q2:*q)
 
     const char *format = *p_format;