Mercurial > cpython-lru_cache-weakref
diff Objects/fileobject.c @ 13210:ff243b0f16ee legacy-trunk
Trent Mick <trentm@activestate.com>:
The common technique for printing out a pointer has been to cast to a long
and use the "%lx" printf modifier. This is incorrect on Win64 where casting
to a long truncates the pointer. The "%p" formatter should be used instead.
The problem as stated by Tim:
> Unfortunately, the C committee refused to define what %p conversion "looks
> like" -- they explicitly allowed it to be implementation-defined. Older
> versions of Microsoft C even stuck a colon in the middle of the address (in
> the days of segment+offset addressing)!
The result is that the hex value of a pointer will maybe/maybe not have a 0x
prepended to it.
Notes on the patch:
There are two main classes of changes:
- in the various repr() functions that print out pointers
- debugging printf's in the various thread_*.h files (these are why the
patch is large)
Closes SourceForge patch #100505.
| author | Fred Drake <fdrake@acm.org> |
|---|---|
| date | Fri, 30 Jun 2000 15:01:00 +0000 |
| parents | 5a7083690884 |
| children | 916fb024ce94 |
line wrap: on
line diff
--- a/Objects/fileobject.c Fri Jun 30 14:58:20 2000 +0000 +++ b/Objects/fileobject.c Fri Jun 30 15:01:00 2000 +0000 @@ -240,11 +240,11 @@ PyFileObject *f; { char buf[300]; - sprintf(buf, "<%s file '%.256s', mode '%.10s' at %lx>", + sprintf(buf, "<%s file '%.256s', mode '%.10s' at %p>", f->f_fp == NULL ? "closed" : "open", PyString_AsString(f->f_name), PyString_AsString(f->f_mode), - (long)f); + f); return PyString_FromString(buf); }
