Mercurial > cpython-lru_cache-weakref
diff Python/thread_lwp.h @ 13210:ff243b0f16ee legacy-trunk
Trent Mick <trentm@activestate.com>:
The common technique for printing out a pointer has been to cast to a long
and use the "%lx" printf modifier. This is incorrect on Win64 where casting
to a long truncates the pointer. The "%p" formatter should be used instead.
The problem as stated by Tim:
> Unfortunately, the C committee refused to define what %p conversion "looks
> like" -- they explicitly allowed it to be implementation-defined. Older
> versions of Microsoft C even stuck a colon in the middle of the address (in
> the days of segment+offset addressing)!
The result is that the hex value of a pointer will maybe/maybe not have a 0x
prepended to it.
Notes on the patch:
There are two main classes of changes:
- in the various repr() functions that print out pointers
- debugging printf's in the various thread_*.h files (these are why the
patch is large)
Closes SourceForge patch #100505.
| author | Fred Drake <fdrake@acm.org> |
|---|---|
| date | Fri, 30 Jun 2000 15:01:00 +0000 |
| parents | 877d23bd5bdc |
| children | 916fb024ce94 |
line wrap: on
line diff
--- a/Python/thread_lwp.h Fri Jun 30 14:58:20 2000 +0000 +++ b/Python/thread_lwp.h Fri Jun 30 15:01:00 2000 +0000 @@ -137,13 +137,13 @@ lock->lock_locked = 0; (void) mon_create(&lock->lock_monitor); (void) cv_create(&lock->lock_condvar, lock->lock_monitor); - dprintf(("PyThread_allocate_lock() -> %lx\n", (long)lock)); + dprintf(("PyThread_allocate_lock() -> %p\n", lock)); return (PyThread_type_lock) lock; } void PyThread_free_lock _P1(lock, PyThread_type_lock lock) { - dprintf(("PyThread_free_lock(%lx) called\n", (long)lock)); + dprintf(("PyThread_free_lock(%p) called\n", lock)); mon_destroy(((struct lock *) lock)->lock_monitor); free((char *) lock); } @@ -152,7 +152,7 @@ { int success; - dprintf(("PyThread_acquire_lock(%lx, %d) called\n", (long)lock, waitflag)); + dprintf(("PyThread_acquire_lock(%p, %d) called\n", lock, waitflag)); success = 0; (void) mon_enter(((struct lock *) lock)->lock_monitor); @@ -165,13 +165,13 @@ } cv_broadcast(((struct lock *) lock)->lock_condvar); mon_exit(((struct lock *) lock)->lock_monitor); - dprintf(("PyThread_acquire_lock(%lx, %d) -> %d\n", (long)lock, waitflag, success)); + dprintf(("PyThread_acquire_lock(%p, %d) -> %d\n", lock, waitflag, success)); return success; } void PyThread_release_lock _P1(lock, PyThread_type_lock lock) { - dprintf(("PyThread_release_lock(%lx) called\n", (long)lock)); + dprintf(("PyThread_release_lock(%p) called\n", lock)); (void) mon_enter(((struct lock *) lock)->lock_monitor); ((struct lock *) lock)->lock_locked = 0; cv_broadcast(((struct lock *) lock)->lock_condvar); @@ -188,23 +188,23 @@ if (!initialized) PyThread_init_thread(); - dprintf(("PyThread_allocate_sema() -> %lx\n", (long) sema)); + dprintf(("PyThread_allocate_sema() -> %p\n", sema)); return (PyThread_type_sema) sema; } void PyThread_free_sema _P1(sema, PyThread_type_sema sema) { - dprintf(("PyThread_free_sema(%lx) called\n", (long) sema)); + dprintf(("PyThread_free_sema(%p) called\n", sema)); } int PyThread_down_sema _P2(sema, PyThread_type_sema sema, waitflag, int waitflag) { - dprintf(("PyThread_down_sema(%lx, %d) called\n", (long) sema, waitflag)); - dprintf(("PyThread_down_sema(%lx) return\n", (long) sema)); + dprintf(("PyThread_down_sema(%p, %d) called\n", sema, waitflag)); + dprintf(("PyThread_down_sema(%p) return\n", sema)); return -1; } void PyThread_up_sema _P1(sema, PyThread_type_sema sema) { - dprintf(("PyThread_up_sema(%lx)\n", (long) sema)); + dprintf(("PyThread_up_sema(%p)\n", sema)); }