Mercurial > cpython-lru_cache-weakref
view Python/fmod.c @ 23312:5dbc79ee0885 2.1
backport tim_one's patch:
Repair widespread misuse of _PyString_Resize. Since it's clear people
don't understand how this function works, also beefed up the docs. The
most common usage error is of this form (often spread out across gotos):
if (_PyString_Resize(&s, n) < 0) {
Py_DECREF(s);
s = NULL;
goto outtahere;
}
The error is that if _PyString_Resize runs out of memory, it automatically
decrefs the input string object s (which also deallocates it, since its
refcount must be 1 upon entry), and sets s to NULL. So if the "if"
branch ever triggers, it's an error to call Py_DECREF(s): s is already
NULL! A correct way to write the above is the simpler (and intended)
if (_PyString_Resize(&s, n) < 0)
goto outtahere;
Bugfix candidate.
Original patch(es):
python/dist/src/Python/bltinmodule.c:2.253
| author | Anthony Baxter <anthonybaxter@gmail.com> |
|---|---|
| date | Tue, 30 Apr 2002 04:01:21 +0000 |
| parents | 6f6f965c5e2d |
| children | 2dea40e40d9d |
line wrap: on
line source
/* Portable fmod(x, y) implementation for systems that don't have it */ #include "config.h" #include "pyport.h" #include <errno.h> double fmod(double x, double y) { double i, f; if (y == 0.0) { errno = EDOM; return 0.0; } /* return f such that x = i*y + f for some integer i such that |f| < |y| and f has the same sign as x */ i = floor(x/y); f = x - i*y; if ((x < 0.0) != (y < 0.0)) f = f-y; return f; }
