Mercurial > cpython-lru_cache-weakref
view Python/thread_nt.h @ 8358:da4bdceeaad7 legacy-trunk
Another veeeeeery old patch...
Date: Thu, 14 Sep 1995 12:18:20 -0400
From: Alan Morse <alan@dvcorp.com>
To: python-list@cwi.nl
Subject: getargs bug in 1.2 and 1.3 BETA
We have found a bug in the part of the getargs code that we added
and submitted, and which was incorporated into 1.1.
The parsing of "O?" format specifiers is not handled correctly;
there is no "else" for the "if" and therefore it can never fail.
What's worse, the advancing of the varargs pointer is not
handled properly, so from then on it is out of sync, wreaking
all sorts of havoc. (If it had failed properly, then the out-of-sync
varargs would not have been an issue.)
Below is the context diff for the change.
Note that I have made a few stylistic changes beyond adding the
else case, namely:
1) Making the "O" case follow the convention established by the other
format specifiers of getting all their vararg arguments before
performing the test, rather than getting some before and some after
the test passes.
2) Making the logic of the tests parallel, so the "if" part indicates
that the format is accepted and the "else" part indicates that the
format has failed. They were inconsistent with each other and with the
the other format specifiers.
-Alan Morse (amorse@dvcorp.com)
| author | Guido van Rossum <guido@python.org> |
|---|---|
| date | Fri, 15 May 1998 22:04:07 +0000 |
| parents | 68f2d7704180 |
| children | 877d23bd5bdc |
line wrap: on
line source
/*********************************************************** Copyright 1991-1995 by Stichting Mathematisch Centrum, Amsterdam, The Netherlands. All Rights Reserved Permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation, and that the names of Stichting Mathematisch Centrum or CWI or Corporation for National Research Initiatives or CNRI not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. While CWI is the initial source for this software, a modified version is made available by the Corporation for National Research Initiatives (CNRI) at the Internet address ftp://ftp.python.org. STICHTING MATHEMATISCH CENTRUM AND CNRI DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO EVENT SHALL STICHTING MATHEMATISCH CENTRUM OR CNRI BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. ******************************************************************/ /* This code implemented by Dag.Gruneau@elsa.preseco.comm.se */ #include <windows.h> #include <limits.h> #include <process.h> long get_thread_ident(void); /* * Change all headers to pure ANSI as no one will use K&R style on an * NT */ /* * Initialization of the C package, should not be needed. */ static void _init_thread(void) { } /* * Thread support. */ int start_new_thread(void (*func)(void *), void *arg) { long rv; int success = 0; dprintf(("%ld: start_new_thread called\n", get_thread_ident())); if (!initialized) init_thread(); rv = _beginthread(func, 0, arg); /* use default stack size */ if (rv != -1) { success = 1; dprintf(("%ld: start_new_thread succeeded: %ld\n", get_thread_ident(), aThreadId)); } return success; } /* * Return the thread Id instead of an handle. The Id is said to uniquely identify the * thread in the system */ long get_thread_ident(void) { if (!initialized) init_thread(); return GetCurrentThreadId(); } static void do_exit_thread(int no_cleanup) { dprintf(("%ld: exit_thread called\n", get_thread_ident())); if (!initialized) if (no_cleanup) _exit(0); else exit(0); _endthread(); } void exit_thread(void) { do_exit_thread(0); } void _exit_thread(void) { do_exit_thread(1); } #ifndef NO_EXIT_PROG static void do_exit_prog(int status, int no_cleanup) { dprintf(("exit_prog(%d) called\n", status)); if (!initialized) if (no_cleanup) _exit(status); else exit(status); } void exit_prog(int status) { do_exit_prog(status, 0); } void _exit_prog _P1(int status) { do_exit_prog(status, 1); } #endif /* NO_EXIT_PROG */ /* * Lock support. It has too be implemented as semaphores. * I [Dag] tried to implement it with mutex but I could find a way to * tell whether a thread already own the lock or not. */ type_lock allocate_lock(void) { HANDLE aLock; dprintf(("allocate_lock called\n")); if (!initialized) init_thread(); aLock = CreateSemaphore(NULL, /* Security attributes */ 1, /* Initial value */ 1, /* Maximum value */ NULL); /* Name of semaphore */ dprintf(("%ld: allocate_lock() -> %lx\n", get_thread_ident(), (long)aLock)); return (type_lock) aLock; } void free_lock(type_lock aLock) { dprintf(("%ld: free_lock(%lx) called\n", get_thread_ident(),(long)aLock)); CloseHandle((HANDLE) aLock); } /* * Return 1 on success if the lock was acquired * * and 0 if the lock was not acquired. This means a 0 is returned * if the lock has already been acquired by this thread! */ int acquire_lock(type_lock aLock, int waitflag) { int success = 1; DWORD waitResult; dprintf(("%ld: acquire_lock(%lx, %d) called\n", get_thread_ident(),(long)aLock, waitflag)); waitResult = WaitForSingleObject((HANDLE) aLock, (waitflag == 1 ? INFINITE : 0)); if (waitResult != WAIT_OBJECT_0) { success = 0; /* We failed */ } dprintf(("%ld: acquire_lock(%lx, %d) -> %d\n", get_thread_ident(),(long)aLock, waitflag, success)); return success; } void release_lock(type_lock aLock) { dprintf(("%ld: release_lock(%lx) called\n", get_thread_ident(),(long)aLock)); if (!ReleaseSemaphore( (HANDLE) aLock, /* Handle of semaphore */ 1, /* increment count by one */ NULL)) /* not interested in previous count */ { dprintf(("%ld: Could not release_lock(%lx) error: %l\n", get_thread_ident(), (long)aLock, GetLastError())); } } /* * Semaphore support. */ type_sema allocate_sema(int value) { HANDLE aSemaphore; dprintf(("%ld: allocate_sema called\n", get_thread_ident())); if (!initialized) init_thread(); aSemaphore = CreateSemaphore( NULL, /* Security attributes */ value, /* Initial value */ INT_MAX, /* Maximum value */ NULL); /* Name of semaphore */ dprintf(("%ld: allocate_sema() -> %lx\n", get_thread_ident(), (long)aSemaphore)); return (type_sema) aSemaphore; } void free_sema(type_sema aSemaphore) { dprintf(("%ld: free_sema(%lx) called\n", get_thread_ident(), (long)aSemaphore)); CloseHandle((HANDLE) aSemaphore); } /* XXX must do something about waitflag */ int down_sema(type_sema aSemaphore, int waitflag) { DWORD waitResult; dprintf(("%ld: down_sema(%lx) called\n", get_thread_ident(), (long)aSemaphore)); waitResult = WaitForSingleObject( (HANDLE) aSemaphore, INFINITE); dprintf(("%ld: down_sema(%lx) return: %l\n", get_thread_ident(),(long) aSemaphore, waitResult)); return 0; } void up_sema(type_sema aSemaphore) { ReleaseSemaphore( (HANDLE) aSemaphore, /* Handle of semaphore */ 1, /* increment count by one */ NULL); /* not interested in previous count */ dprintf(("%ld: up_sema(%lx)\n", get_thread_ident(), (long)aSemaphore)); }
