https://hg.dopieralski.pl/cpython-lru_cache-weakref/ en-us cpython-lru_cache-weakref: Modules/_posixsubprocess.c history Modules/_posixsubprocess.c revision history null merge (3.4 already has its own fix for this). https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/786a106fc6b7/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sun, 01 Dec 2013 17:28:24 -0800 Undo supposed fix for Issue #15798 until I understand why this is https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/ddbf9632795b/Modules/_posixsubprocess.c causing test_multiprocessing_forkserver and test_multiprocessing_spawn
failures on head (3.4).]]> Gregory P. Smith <greg@krypto.org> Sun, 01 Dec 2013 00:13:35 -0800 Fixes Issue #15798 - subprocess.Popen() no longer fails if file https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/0387054b2038/Modules/_posixsubprocess.c descriptor 0, 1 or 2 is closed.]]> Gregory P. Smith <greg@krypto.org> Sat, 30 Nov 2013 19:04:00 -0800 Issue #18571: Implementation of the PEP 446: file descriptors and file handles https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/ef889c3d5dc6/Modules/_posixsubprocess.c are now created non-inheritable; add functions os.get/set_inheritable(),
os.get/set_handle_inheritable() and socket.socket.get/set_inheritable().]]> Victor Stinner <victor.stinner@gmail.com> Wed, 28 Aug 2013 00:53:59 +0200 Issue #18763: subprocess: The file descriptors are now closed after calling the https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/748a5d39e7ce/Modules/_posixsubprocess.c preexec_fn callback, which may open file descriptors.]]> Charles-François Natali <cf.natali@gmail.com> Sun, 25 Aug 2013 18:25:38 +0200 Fixes Issue #16962: Use getdents64 instead of the obsolete getdents syscall https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/7ab1c55fcf82/Modules/_posixsubprocess.c in the subprocess module on Linux.]]> Gregory P. Smith <greg@krypto.org> Sun, 03 Mar 2013 10:53:27 -0800 Raise our own SubprocessError rather than a RuntimeError in when dealing with https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/9180fb4eccc7/Modules/_posixsubprocess.c odd rare errors coming from the subprocess module.]]> Gregory P. Smith <greg@krypto.org> Sat, 10 Nov 2012 23:53:47 -0800 Fixes issue #15798: subprocess.Popen() no longer fails if file https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/07425df887b5/Modules/_posixsubprocess.c descriptor 0, 1 or 2 is closed.
The errpipe_write fd will always be >= 3.]]> Gregory P. Smith <greg@krypto.org> Sun, 01 Dec 2013 17:27:40 -0800 Undo supposed fix for Issue #15798 until I understand why this is https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/efcdf2a70f2a/Modules/_posixsubprocess.c causing test_multiprocessing_forkserver and test_multiprocessing_spawn
failures on head (3.4).]]> Gregory P. Smith <greg@krypto.org> Sun, 01 Dec 2013 00:12:24 -0800 Fixes Issue #15798 - subprocess.Popen() no longer fails if file https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/c4cd891cf167/Modules/_posixsubprocess.c descriptor 0, 1 or 2 is closed.]]> Gregory P. Smith <greg@krypto.org> Sat, 30 Nov 2013 19:02:57 -0800 Issue #18763: subprocess: The file descriptors are now closed after calling the https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/4c52d4bac03c/Modules/_posixsubprocess.c preexec_fn callback, which may open file descriptors.]]> Charles-François Natali <cf.natali@gmail.com> Sun, 25 Aug 2013 18:24:45 +0200 Issue #16962: Use getdents64 instead of the obsolete getdents syscall in https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/30e643e36bae/Modules/_posixsubprocess.c the subprocess module on Linux.]]> Gregory P. Smith <greg@krypto.org> Sun, 03 Mar 2013 10:45:05 -0800 Fixes Issue #16114: The subprocess module no longer provides a https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/ee30d7ef70be/Modules/_posixsubprocess.c misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.]]> Gregory P. Smith <greg@krypto.org> Wed, 10 Oct 2012 03:44:47 -0700 Merge with 3.2 https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/c2df6d55f4d2/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Fri, 24 Aug 2012 13:32:14 +0200 Merge 3.2. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/5b1b9cfb7fe8/Modules/_posixsubprocess.c Stefan Krah <skrah@bytereef.org> Mon, 20 Aug 2012 14:42:59 +0200 Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/b878df1d23b1/Modules/_posixsubprocess.c Patch by Serhiy Storchaka.]]> Antoine Pitrou <solipsis@pitrou.net> Wed, 15 Aug 2012 23:20:39 +0200 Fixes issue #15000: support the odd x32 abi on posixsubprocess's system call. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/5a4d5e714d08/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Tue, 05 Jun 2012 13:30:24 -0700 Merge with 3.2 for #14359. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/0d5fcbfd646f/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Mon, 19 Mar 2012 06:13:13 +0200 Issue 14359: Only use O_CLOEXEC in _posixmodule.c if it is defined. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/fe1dfc066a38/Modules/_posixsubprocess.c
Based on patch from Hervé Coatanhay.]]> Ross Lagerwall <rosslagerwall@gmail.com> Sun, 18 Mar 2012 15:55:10 +0200 Use ANSI C prototype instead of K&R style. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/e4c3a3a6371f/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Wed, 07 Mar 2012 20:06:33 +0200 merge 3.2 https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/d90f943b0c92/Modules/_posixsubprocess.c Benjamin Peterson <benjamin@python.org> Sun, 22 Jan 2012 20:04:58 -0500 Fix FreeBSD, NetBSD and OpenBSD behavior of the issue #8052 fix. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/7d4658a8de96/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 21:06:22 -0800 bugfix for *BSD platforms. (oops messed up #define) https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/665b748ee4c1/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 15:20:37 -0800 bugfix for issue 8052 fixes on *BSD platforms. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/e52d81e0c750/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 15:20:08 -0800 Fixes issue #8052: The posix subprocess module's close_fds behavior was https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/8879874d66a2/Modules/_posixsubprocess.c suboptimal by closing all possible file descriptors rather than just
the open ones in the child process before exec().

It now closes only the open fds when it is possible to safely determine what
those are.]]> Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 14:39:29 -0800 Avoid the compiler warning about the unused return value. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/bd9cf92cfa97/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 12:51:30 -0800 Merge with 3.2. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/9682a975bc1e/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Thu, 22 Dec 2011 09:46:44 +0200 Merge with 3.2 for #11006. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/b1b35583967a/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Thu, 22 Dec 2011 09:10:47 +0200 Rename _Py_identifier to _Py_IDENTIFIER. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/7109f31300fb/Modules/_posixsubprocess.c Martin v. Löwis <martin@v.loewis.de> Fri, 14 Oct 2011 10:20:37 +0200 Add API for static strings, primarily good for identifiers. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/5e33219492bc/Modules/_posixsubprocess.c Thanks to Konrad Schöbel and Jasper Schulz for helping with the mass-editing.]]> Martin v. Löwis <martin@v.loewis.de> Sun, 09 Oct 2011 10:38:36 +0200 Issue #12607: Merge with 3.2. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/943d323cb4b8/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Wed, 27 Jul 2011 07:39:27 +0200 _posixsubprocess.c: don't redefine _GNU_SOURCE if it's already defined https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/53ea5663b290/Modules/_posixsubprocess.c Victor Stinner <victor.stinner@haypocalc.com> Thu, 26 May 2011 14:10:08 +0200 Fixes Issue #16114: The subprocess module no longer provides a https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/e938fa6be509/Modules/_posixsubprocess.c misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.

It now keeps track of if the child got as far as preexec and reports it if
not back to the parent via a special "noexec" error message value in
the error pipe so that the cwd can be blamed for a failed chdir
instead of the exec of the executable being blamed instead.

The executable is also always reported accurately when exec fails.

Unittests enhanced to cover these cases.]]> Gregory P. Smith <greg@krypto.org> Wed, 10 Oct 2012 03:34:47 -0700 Issue 15777: Fix a refleak in _posixsubprocess. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/081507b4ae40/Modules/_posixsubprocess.c
It was exposed by 03c98d05b140 and dbbf3ccf72e8.]]> Ross Lagerwall <rosslagerwall@gmail.com> Fri, 24 Aug 2012 13:25:59 +0200 Issue #15738: Fix a missing NULL check in subprocess_fork_exec(). https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/03c98d05b140/Modules/_posixsubprocess.c Stefan Krah <skrah@bytereef.org> Mon, 20 Aug 2012 14:36:47 +0200 Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/56dc7b09f390/Modules/_posixsubprocess.c Patch by Serhiy Storchaka.]]> Antoine Pitrou <solipsis@pitrou.net> Wed, 15 Aug 2012 23:18:25 +0200 Fixes issue #15000: support the odd x32 abi on posixsubprocess's system call. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/aa9cfeea07ad/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Tue, 05 Jun 2012 13:26:39 -0700 Issue #14359: Only use O_CLOEXEC in _posixmodule.c if it is defined. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/09371e2ae84d/Modules/_posixsubprocess.c
Based on patch from Hervé Coatanhay.]]> Ross Lagerwall <rosslagerwall@gmail.com> Mon, 19 Mar 2012 06:08:43 +0200 fix declaration style https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/308f4af9548e/Modules/_posixsubprocess.c Benjamin Peterson <benjamin@python.org> Sun, 22 Jan 2012 20:04:46 -0500 Fix FreeBSD, NetBSD and OpenBSD behavior of the issue #8052 fix. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/754c2eb0a92c/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 21:01:24 -0800 Another issue #8052 bugfix (related to previous commit). https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/5be3dadd2eef/Modules/_posixsubprocess.c "oops" while rearranging the #defines.]]> Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 15:19:11 -0800 Bugfix for issue #8052 fix on *BSD variants. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/d0acd8169c2a/Modules/_posixsubprocess.c
Many lack readdir64, use readdir. Only use readdir64 on solaris where
it is required to work around a solaris bug.]]> Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 15:16:17 -0800 Fixes issue #8052: The posix subprocess module's close_fds behavior was https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/61aa484a3e54/Modules/_posixsubprocess.c suboptimal by closing all possible file descriptors rather than just
the open ones in the child process before exec().

It now closes only the open fds when it is possible to safely determine what
those are.]]> Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 14:01:08 -0800 Avoid the compiler warning about the unused return value. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/d01fecadf3ea/Modules/_posixsubprocess.c Gregory P. Smith <greg@krypto.org> Sat, 21 Jan 2012 12:31:25 -0800 Don't redefine _GNU_SOURCE if it's already defined. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/69eee9084ba3/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Thu, 22 Dec 2011 09:45:53 +0200 Issue #11006: Don't issue low level warning in subprocess when pipe2() fails. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/dc913f73a7fb/Modules/_posixsubprocess.c Ross Lagerwall <rosslagerwall@gmail.com> Thu, 22 Dec 2011 09:07:30 +0200 Issue #12607: In subprocess, fix issue where if stdin, stdout or stderr is https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/1140b32747c9/Modules/_posixsubprocess.c given as a low fd, it gets overwritten.]]> Ross Lagerwall <rosslagerwall@gmail.com> Wed, 27 Jul 2011 07:16:31 +0200 Fix issue #11432. if the stdin pipe is the same file descriptor as either stdout or stderr https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/adcf03b074b7/Modules/_posixsubprocess.c in the _posixsubprocess C extension module it would unintentionally close the fds and raise
an error.]]> Gregory P. Smith <greg@krypto.org> Tue, 15 Mar 2011 14:56:39 -0400 Issue #10806, issue #9905: Fix subprocess pipes when some of the standard https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/a66a6e42538f/Modules/_posixsubprocess.c file descriptors (0, 1, 2) are closed in the parent process. Initial
patch by Ross Lagerwall.]]> Antoine Pitrou <solipsis@pitrou.net> Mon, 03 Jan 2011 18:23:55 +0000 issue10802: fallback to pipe+fcntl when the pipe2 syscall fails with errno ENOSYS. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/a5ae3a17d5fb/Modules/_posixsubprocess.c Gregory P. Smith <greg@mad-scientist.com> Sun, 02 Jan 2011 20:52:48 +0000 fix a compiler warning about err_msg potentially being used uninitialized. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/a82df209858a/Modules/_posixsubprocess.c Gregory P. Smith <greg@mad-scientist.com> Wed, 22 Dec 2010 05:22:17 +0000 Issue #6559: fix the subprocess.Popen pass_fds implementation. Add a unittest. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/59b43dc34158/Modules/_posixsubprocess.c Issue #7213: Change the close_fds default on Windows to better match the new
default on POSIX. True when possible (False if stdin/stdout/stderr are
supplied).

Update the documentation to reflect all of the above.]]> Gregory P. Smith <greg@mad-scientist.com> Tue, 14 Dec 2010 13:43:30 +0000 issue7213: Open the pipes used by subprocesses with the FD_CLOEXEC flag from https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/de05d846795e/Modules/_posixsubprocess.c the C code, using pipe2() when available. Adds unittests for close_fds and
cloexec behaviors.]]> Gregory P. Smith <greg@mad-scientist.com> Mon, 13 Dec 2010 07:59:39 +0000 issue6559: Adds a pass_fds parameter to subprocess.Popen that allows the caller https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/296e6f85f56d/Modules/_posixsubprocess.c to list exactly which file descriptors should be kept open.]]> Gregory P. Smith <greg@mad-scientist.com> Sat, 04 Dec 2010 11:22:11 +0000 Issue #8485: PyUnicode_FSConverter() doesn't accept bytearray object anymore, https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/dd18cccb55b0/Modules/_posixsubprocess.c you have to convert your bytearray filenames to bytes]]> Victor Stinner <victor.stinner@haypocalc.com> Thu, 22 Apr 2010 12:08:36 +0000 Issue #8393: subprocess accepts bytes, bytearray and str with surrogates for https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/dc765bca24ad/Modules/_posixsubprocess.c the current working directory.

Remove also a trailing space, and replace tabulation indentation by spaces.]]> Victor Stinner <victor.stinner@haypocalc.com> Fri, 16 Apr 2010 23:49:32 +0000 * Fix a refleak when a preexec_fn was supplied (preexec_fn_args_tuple was not https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/00daa8b736cc/Modules/_posixsubprocess.c being defref'ed).
* Fixes another potential refleak of a reference to the gc
module in the unlikely odd case where gc module isenabled or disable calls
fail.
* Adds a unittest for the above case to verify behavior and lack of leaks.]]> Gregory P. Smith <greg@mad-scientist.com> Fri, 19 Mar 2010 16:53:08 +0000 * Fix the refcount leak in _PySequence_BytesToCharpArray from r78946. https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/adb5e928bde2/Modules/_posixsubprocess.c * Also fixes a potential extra DECREF of an arg in the error case within
_posixsubprocess.fork_exec() by not reusing the process_args variable.]]> Gregory P. Smith <greg@mad-scientist.com> Mon, 15 Mar 2010 06:07:42 +0000 * Replaces the internals of the subprocess module from fork through exec on https://hg.dopieralski.pl/cpython-lru_cache-weakref/log/768722b2ae0a/Modules/_posixsubprocess.c POSIX systems with a C extension module. This is required in order for
the subprocess module to be made thread safe.

The pure python implementation is retained so that it can continue to be
used if for some reason the _posixsubprocess extension module is not
available.

The unittest executes tests on both code paths to guarantee compatibility.

* Moves PyLong_FromPid and PyLong_AsPid from posixmodule.c into longobject.h.

Code reviewed by jeffrey.yasskin at http://codereview.appspot.com/223077/show]]> Gregory P. Smith <greg@mad-scientist.com> Sun, 14 Mar 2010 06:49:55 +0000