Mercurial > cpython-lru_cache-weakref
annotate Modules/_struct.c @ 59436:cfb442d702cd legacy-trunk
Issue #1530559: When packing a non-integer with any integer conversion
code using struct.pack, attempt to convert to an integer first using
the argument's __int__ method (if present). Also raise a
DeprecationWarning for any such usage of __int__.
This fixes a regression from 2.6, where some (but not all) integer
conversion codes already used __int__.
| author | Mark Dickinson <dickinsm@gmail.com> |
|---|---|
| date | Sun, 07 Mar 2010 16:24:45 +0000 |
| parents | fd155a368f5b |
| children | 4a6be864c6b8 |
| rev | line source |
|---|---|
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1 /* struct module -- pack values into and (out of) strings */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
2 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
3 /* New version supporting byte order, alignment and size options, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
4 character strings, and unsigned numbers */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
5 |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
6 #define PY_SSIZE_T_CLEAN |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
7 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
8 #include "Python.h" |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
9 #include "structseq.h" |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
10 #include "structmember.h" |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
11 #include <ctype.h> |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
12 |
|
38266
74c82ebc4e44
forward declaration for PyStructType
Bob Ippolito <bob@redivi.com>
parents:
38264
diff
changeset
|
13 static PyTypeObject PyStructType; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
14 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
15 /* compatibility macros */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
16 #if (PY_VERSION_HEX < 0x02050000) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
17 typedef int Py_ssize_t; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
18 #endif |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
19 |
|
59436
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
20 /* warning messages */ |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
21 #define FLOAT_COERCE_WARN "integer argument expected, got float" |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
22 #define NON_INTEGER_WARN "integer argument expected, got non-integer " \ |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
23 "(implicit conversion using __int__ is deprecated)" |
|
39380
9cb4565e60ca
Fix #1530559, struct.pack raises TypeError where it used to convert.
Bob Ippolito <bob@redivi.com>
parents:
39301
diff
changeset
|
24 |
|
9cb4565e60ca
Fix #1530559, struct.pack raises TypeError where it used to convert.
Bob Ippolito <bob@redivi.com>
parents:
39301
diff
changeset
|
25 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
26 /* The translation function for each format character is table driven */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
27 typedef struct _formatdef { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
28 char format; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
29 Py_ssize_t size; |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
30 Py_ssize_t alignment; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
31 PyObject* (*unpack)(const char *, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
32 const struct _formatdef *); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
33 int (*pack)(char *, PyObject *, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
34 const struct _formatdef *); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
35 } formatdef; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
36 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
37 typedef struct _formatcode { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
38 const struct _formatdef *fmtdef; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
39 Py_ssize_t offset; |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
40 Py_ssize_t size; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
41 } formatcode; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
42 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
43 /* Struct object interface */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
44 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
45 typedef struct { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
46 PyObject_HEAD |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
47 Py_ssize_t s_size; |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
48 Py_ssize_t s_len; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
49 formatcode *s_codes; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
50 PyObject *s_format; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
51 PyObject *weakreflist; /* List of weak references */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
52 } PyStructObject; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
53 |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
54 |
| 38267 | 55 #define PyStruct_Check(op) PyObject_TypeCheck(op, &PyStructType) |
|
44350
26384b8180c7
#1629: Renamed Py_Size, Py_Type and Py_Refcnt to Py_SIZE, Py_TYPE and Py_REFCNT. Macros for b/w compatibility are available.
Christian Heimes <christian@cheimes.de>
parents:
42333
diff
changeset
|
56 #define PyStruct_CheckExact(op) (Py_TYPE(op) == &PyStructType) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
57 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
58 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
59 /* Exception */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
60 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
61 static PyObject *StructError; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
62 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
63 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
64 /* Define various structs to figure out the alignments of types */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
65 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
66 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
67 typedef struct { char c; short x; } st_short; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
68 typedef struct { char c; int x; } st_int; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
69 typedef struct { char c; long x; } st_long; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
70 typedef struct { char c; float x; } st_float; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
71 typedef struct { char c; double x; } st_double; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
72 typedef struct { char c; void *x; } st_void_p; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
73 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
74 #define SHORT_ALIGN (sizeof(st_short) - sizeof(short)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
75 #define INT_ALIGN (sizeof(st_int) - sizeof(int)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
76 #define LONG_ALIGN (sizeof(st_long) - sizeof(long)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
77 #define FLOAT_ALIGN (sizeof(st_float) - sizeof(float)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
78 #define DOUBLE_ALIGN (sizeof(st_double) - sizeof(double)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
79 #define VOID_P_ALIGN (sizeof(st_void_p) - sizeof(void *)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
80 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
81 /* We can't support q and Q in native mode unless the compiler does; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
82 in std mode, they're 8 bytes on all platforms. */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
83 #ifdef HAVE_LONG_LONG |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
84 typedef struct { char c; PY_LONG_LONG x; } s_long_long; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
85 #define LONG_LONG_ALIGN (sizeof(s_long_long) - sizeof(PY_LONG_LONG)) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
86 #endif |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
87 |
|
40681
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
88 #ifdef HAVE_C99_BOOL |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
89 #define BOOL_TYPE _Bool |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
90 typedef struct { char c; _Bool x; } s_bool; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
91 #define BOOL_ALIGN (sizeof(s_bool) - sizeof(BOOL_TYPE)) |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
92 #else |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
93 #define BOOL_TYPE char |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
94 #define BOOL_ALIGN 0 |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
95 #endif |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
96 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
97 #define STRINGIFY(x) #x |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
98 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
99 #ifdef __powerc |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
100 #pragma options align=reset |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
101 #endif |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
102 |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
103 static char *integer_codes = "bBhHiIlLqQ"; |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
104 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
105 /* Helper to get a PyLongObject by hook or by crook. Caller should decref. */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
106 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
107 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
108 get_pylong(PyObject *v) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
109 { |
|
59436
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
110 PyObject *r; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
111 assert(v != NULL); |
|
59436
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
112 if (!PyInt_Check(v) && !PyLong_Check(v)) { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
113 PyNumberMethods *m; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
114 /* Not an integer; try to use __int__ to convert to an |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
115 integer. This behaviour is deprecated, and is removed in |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
116 Python 3.x. */ |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
117 m = Py_TYPE(v)->tp_as_number; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
118 if (m != NULL && m->nb_int != NULL) { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
119 /* Special case warning message for floats, for |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
120 backwards compatibility. */ |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
121 if (PyFloat_Check(v)) { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
122 if (PyErr_WarnEx(PyExc_DeprecationWarning, |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
123 FLOAT_COERCE_WARN, 1)) |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
124 return NULL; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
125 } |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
126 else { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
127 if (PyErr_WarnEx(PyExc_DeprecationWarning, |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
128 NON_INTEGER_WARN, 1)) |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
129 return NULL; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
130 } |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
131 v = m->nb_int(v); |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
132 if (v == NULL) |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
133 return NULL; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
134 if (!PyInt_Check(v) && !PyLong_Check(v)) { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
135 PyErr_SetString(PyExc_TypeError, |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
136 "__int__ method returned non-integer"); |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
137 return NULL; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
138 } |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
139 } |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
140 else { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
141 PyErr_SetString(StructError, |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
142 "cannot convert argument to integer"); |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
143 return NULL; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
144 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
145 } |
|
59436
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
146 else |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
147 /* Ensure we own a reference to v. */ |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
148 Py_INCREF(v); |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
149 |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
150 if (PyInt_Check(v)) { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
151 r = PyLong_FromLong(PyInt_AS_LONG(v)); |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
152 Py_DECREF(v); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
153 } |
|
59436
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
154 else if (PyLong_Check(v)) { |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
155 assert(PyLong_Check(v)); |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
156 r = v; |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
157 } |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
158 else |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
159 assert(0); /* shouldn't ever get here */ |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
160 |
|
cfb442d702cd
Issue #1530559: When packing a non-integer with any integer conversion
Mark Dickinson <dickinsm@gmail.com>
parents:
59368
diff
changeset
|
161 return r; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
162 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
163 |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
164 /* Helper to convert a Python object to a C long. Sets an exception |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
165 (struct.error for an inconvertible type, OverflowError for |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
166 out-of-range values) and returns -1 on error. */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
167 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
168 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
169 get_long(PyObject *v, long *p) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
170 { |
|
55121
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
171 long x; |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
172 |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
173 v = get_pylong(v); |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
174 if (v == NULL) |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
175 return -1; |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
176 assert(PyLong_Check(v)); |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
177 x = PyLong_AsLong(v); |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
178 Py_DECREF(v); |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
179 if (x == (long)-1 && PyErr_Occurred()) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
180 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
181 *p = x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
182 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
183 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
184 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
185 /* Same, but handling unsigned long */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
186 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
187 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
188 get_ulong(PyObject *v, unsigned long *p) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
189 { |
|
55121
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
190 unsigned long x; |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
191 |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
192 v = get_pylong(v); |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
193 if (v == NULL) |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
194 return -1; |
|
55121
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
195 assert(PyLong_Check(v)); |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
196 x = PyLong_AsUnsignedLong(v); |
|
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
197 Py_DECREF(v); |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
198 if (x == (unsigned long)-1 && PyErr_Occurred()) |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
199 return -1; |
|
55121
1fc37fecaf8f
Issues #1530559, #1741130: Fix various inconsistencies in struct.pack
Mark Dickinson <dickinsm@gmail.com>
parents:
54412
diff
changeset
|
200 *p = x; |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
201 return 0; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
202 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
203 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
204 #ifdef HAVE_LONG_LONG |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
205 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
206 /* Same, but handling native long long. */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
207 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
208 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
209 get_longlong(PyObject *v, PY_LONG_LONG *p) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
210 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
211 PY_LONG_LONG x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
212 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
213 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
214 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
215 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
216 assert(PyLong_Check(v)); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
217 x = PyLong_AsLongLong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
218 Py_DECREF(v); |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
219 if (x == (PY_LONG_LONG)-1 && PyErr_Occurred()) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
220 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
221 *p = x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
222 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
223 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
224 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
225 /* Same, but handling native unsigned long long. */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
226 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
227 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
228 get_ulonglong(PyObject *v, unsigned PY_LONG_LONG *p) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
229 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
230 unsigned PY_LONG_LONG x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
231 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
232 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
233 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
234 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
235 assert(PyLong_Check(v)); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
236 x = PyLong_AsUnsignedLongLong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
237 Py_DECREF(v); |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
238 if (x == (unsigned PY_LONG_LONG)-1 && PyErr_Occurred()) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
239 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
240 *p = x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
241 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
242 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
243 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
244 #endif |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
245 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
246 /* Floating point helpers */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
247 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
248 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
249 unpack_float(const char *p, /* start of 4-byte string */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
250 int le) /* true for little-endian, false for big-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
251 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
252 double x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
253 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
254 x = _PyFloat_Unpack4((unsigned char *)p, le); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
255 if (x == -1.0 && PyErr_Occurred()) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
256 return NULL; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
257 return PyFloat_FromDouble(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
258 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
259 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
260 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
261 unpack_double(const char *p, /* start of 8-byte string */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
262 int le) /* true for little-endian, false for big-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
263 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
264 double x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
265 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
266 x = _PyFloat_Unpack8((unsigned char *)p, le); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
267 if (x == -1.0 && PyErr_Occurred()) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
268 return NULL; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
269 return PyFloat_FromDouble(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
270 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
271 |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
272 /* Helper to format the range error exceptions */ |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
273 static int |
| 38484 | 274 _range_error(const formatdef *f, int is_unsigned) |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
275 { |
|
38529
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
276 /* ulargest is the largest unsigned value with f->size bytes. |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
277 * Note that the simpler: |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
278 * ((size_t)1 << (f->size * 8)) - 1 |
|
38530
447a94b039de
Repaired error in new comment.
Tim Peters <tim.peters@gmail.com>
parents:
38529
diff
changeset
|
279 * doesn't work when f->size == sizeof(size_t) because C doesn't |
|
447a94b039de
Repaired error in new comment.
Tim Peters <tim.peters@gmail.com>
parents:
38529
diff
changeset
|
280 * define what happens when a left shift count is >= the number of |
|
447a94b039de
Repaired error in new comment.
Tim Peters <tim.peters@gmail.com>
parents:
38529
diff
changeset
|
281 * bits in the integer being shifted; e.g., on some boxes it doesn't |
|
447a94b039de
Repaired error in new comment.
Tim Peters <tim.peters@gmail.com>
parents:
38529
diff
changeset
|
282 * shift at all when they're equal. |
|
38529
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
283 */ |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
284 const size_t ulargest = (size_t)-1 >> ((SIZEOF_SIZE_T - f->size)*8); |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
285 assert(f->size >= 1 && f->size <= SIZEOF_SIZE_T); |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
286 if (is_unsigned) |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
287 PyErr_Format(StructError, |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
288 "'%c' format requires 0 <= number <= %zu", |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
289 f->format, |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
290 ulargest); |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
291 else { |
|
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
292 const Py_ssize_t largest = (Py_ssize_t)(ulargest >> 1); |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
293 PyErr_Format(StructError, |
|
38520
1a56da86c11a
Calculate smallest properly (it was off by one) and use proper ssize_t types for Win64
Neal Norwitz <nnorwitz@gmail.com>
parents:
38515
diff
changeset
|
294 "'%c' format requires %zd <= number <= %zd", |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
295 f->format, |
|
38529
a7f2295a78ac
_range_error(): Speed and simplify (there's no real need for
Tim Peters <tim.peters@gmail.com>
parents:
38528
diff
changeset
|
296 ~ largest, |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
297 largest); |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
298 } |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
299 return -1; |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
300 } |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
301 |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
302 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
303 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
304 /* A large number of small routines follow, with names of the form |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
305 |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
306 [bln][up]_TYPE |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
307 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
308 [bln] distiguishes among big-endian, little-endian and native. |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
309 [pu] distiguishes between pack (to struct) and unpack (from struct). |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
310 TYPE is one of char, byte, ubyte, etc. |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
311 */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
312 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
313 /* Native mode routines. ****************************************************/ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
314 /* NOTE: |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
315 In all n[up]_<type> routines handling types larger than 1 byte, there is |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
316 *no* guarantee that the p pointer is properly aligned for each type, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
317 therefore memcpy is called. An intermediate variable is used to |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
318 compensate for big-endian architectures. |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
319 Normally both the intermediate variable and the memcpy call will be |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
320 skipped by C optimisation in little-endian architectures (gcc >= 2.91 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
321 does this). */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
322 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
323 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
324 nu_char(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
325 { |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
326 return PyString_FromStringAndSize(p, 1); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
327 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
328 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
329 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
330 nu_byte(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
331 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
332 return PyInt_FromLong((long) *(signed char *)p); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
333 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
334 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
335 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
336 nu_ubyte(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
337 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
338 return PyInt_FromLong((long) *(unsigned char *)p); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
339 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
340 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
341 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
342 nu_short(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
343 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
344 short x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
345 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
346 return PyInt_FromLong((long)x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
347 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
348 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
349 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
350 nu_ushort(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
351 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
352 unsigned short x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
353 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
354 return PyInt_FromLong((long)x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
355 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
356 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
357 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
358 nu_int(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
359 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
360 int x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
361 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
362 return PyInt_FromLong((long)x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
363 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
364 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
365 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
366 nu_uint(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
367 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
368 unsigned int x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
369 memcpy((char *)&x, p, sizeof x); |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
370 #if (SIZEOF_LONG > SIZEOF_INT) |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
371 return PyInt_FromLong((long)x); |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
372 #else |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
373 if (x <= ((unsigned int)LONG_MAX)) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
374 return PyInt_FromLong((long)x); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
375 return PyLong_FromUnsignedLong((unsigned long)x); |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
376 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
377 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
378 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
379 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
380 nu_long(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
381 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
382 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
383 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
384 return PyInt_FromLong(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
385 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
386 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
387 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
388 nu_ulong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
389 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
390 unsigned long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
391 memcpy((char *)&x, p, sizeof x); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
392 if (x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
393 return PyInt_FromLong((long)x); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
394 return PyLong_FromUnsignedLong(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
395 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
396 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
397 /* Native mode doesn't support q or Q unless the platform C supports |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
398 long long (or, on Windows, __int64). */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
399 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
400 #ifdef HAVE_LONG_LONG |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
401 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
402 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
403 nu_longlong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
404 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
405 PY_LONG_LONG x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
406 memcpy((char *)&x, p, sizeof x); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
407 if (x >= LONG_MIN && x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
408 return PyInt_FromLong(Py_SAFE_DOWNCAST(x, PY_LONG_LONG, long)); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
409 return PyLong_FromLongLong(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
410 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
411 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
412 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
413 nu_ulonglong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
414 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
415 unsigned PY_LONG_LONG x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
416 memcpy((char *)&x, p, sizeof x); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
417 if (x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
418 return PyInt_FromLong(Py_SAFE_DOWNCAST(x, unsigned PY_LONG_LONG, long)); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
419 return PyLong_FromUnsignedLongLong(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
420 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
421 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
422 #endif |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
423 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
424 static PyObject * |
|
40681
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
425 nu_bool(const char *p, const formatdef *f) |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
426 { |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
427 BOOL_TYPE x; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
428 memcpy((char *)&x, p, sizeof x); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
429 return PyBool_FromLong(x != 0); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
430 } |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
431 |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
432 |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
433 static PyObject * |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
434 nu_float(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
435 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
436 float x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
437 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
438 return PyFloat_FromDouble((double)x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
439 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
440 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
441 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
442 nu_double(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
443 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
444 double x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
445 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
446 return PyFloat_FromDouble(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
447 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
448 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
449 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
450 nu_void_p(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
451 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
452 void *x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
453 memcpy((char *)&x, p, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
454 return PyLong_FromVoidPtr(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
455 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
456 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
457 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
458 np_byte(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
459 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
460 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
461 if (get_long(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
462 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
463 if (x < -128 || x > 127){ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
464 PyErr_SetString(StructError, |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
465 "byte format requires -128 <= number <= 127"); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
466 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
467 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
468 *p = (char)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
469 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
470 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
471 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
472 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
473 np_ubyte(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
474 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
475 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
476 if (get_long(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
477 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
478 if (x < 0 || x > 255){ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
479 PyErr_SetString(StructError, |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
480 "ubyte format requires 0 <= number <= 255"); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
481 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
482 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
483 *p = (char)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
484 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
485 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
486 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
487 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
488 np_char(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
489 { |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
490 if (!PyString_Check(v) || PyString_Size(v) != 1) { |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
491 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
492 "char format require string of length 1"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
493 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
494 } |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
495 *p = *PyString_AsString(v); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
496 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
497 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
498 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
499 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
500 np_short(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
501 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
502 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
503 short y; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
504 if (get_long(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
505 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
506 if (x < SHRT_MIN || x > SHRT_MAX){ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
507 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
508 "short format requires " STRINGIFY(SHRT_MIN) |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
509 " <= number <= " STRINGIFY(SHRT_MAX)); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
510 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
511 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
512 y = (short)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
513 memcpy(p, (char *)&y, sizeof y); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
514 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
515 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
516 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
517 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
518 np_ushort(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
519 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
520 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
521 unsigned short y; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
522 if (get_long(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
523 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
524 if (x < 0 || x > USHRT_MAX){ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
525 PyErr_SetString(StructError, |
|
55142
880b50bca1b1
Typo in error message
Mark Dickinson <dickinsm@gmail.com>
parents:
55121
diff
changeset
|
526 "ushort format requires 0 <= number <= " STRINGIFY(USHRT_MAX)); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
527 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
528 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
529 y = (unsigned short)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
530 memcpy(p, (char *)&y, sizeof y); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
531 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
532 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
533 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
534 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
535 np_int(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
536 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
537 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
538 int y; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
539 if (get_long(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
540 return -1; |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
541 #if (SIZEOF_LONG > SIZEOF_INT) |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
542 if ((x < ((long)INT_MIN)) || (x > ((long)INT_MAX))) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
543 return _range_error(f, 0); |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
544 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
545 y = (int)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
546 memcpy(p, (char *)&y, sizeof y); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
547 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
548 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
549 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
550 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
551 np_uint(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
552 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
553 unsigned long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
554 unsigned int y; |
|
56246
3dec3b77b787
Eliminate unnecessary get_wrapped_(u)long defines in struct module.
Mark Dickinson <dickinsm@gmail.com>
parents:
55153
diff
changeset
|
555 if (get_ulong(v, &x) < 0) |
|
50424
df3923c36ec5
Merged revisions 67952-67953,67955,67957-67958,67960-67961,67963,67965,67967,67970-67971,67973,67982,67988,67990,67995,68014,68016,68030,68057,68061,68112,68115-68118,68120-68121,68123-68128 via svnmerge from
Georg Brandl <georg@python.org>
parents:
49351
diff
changeset
|
556 return -1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
557 y = (unsigned int)x; |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
558 #if (SIZEOF_LONG > SIZEOF_INT) |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
559 if (x > ((unsigned long)UINT_MAX)) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
560 return _range_error(f, 1); |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
561 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
562 memcpy(p, (char *)&y, sizeof y); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
563 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
564 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
565 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
566 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
567 np_long(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
568 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
569 long x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
570 if (get_long(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
571 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
572 memcpy(p, (char *)&x, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
573 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
574 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
575 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
576 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
577 np_ulong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
578 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
579 unsigned long x; |
|
56246
3dec3b77b787
Eliminate unnecessary get_wrapped_(u)long defines in struct module.
Mark Dickinson <dickinsm@gmail.com>
parents:
55153
diff
changeset
|
580 if (get_ulong(v, &x) < 0) |
|
50424
df3923c36ec5
Merged revisions 67952-67953,67955,67957-67958,67960-67961,67963,67965,67967,67970-67971,67973,67982,67988,67990,67995,68014,68016,68030,68057,68061,68112,68115-68118,68120-68121,68123-68128 via svnmerge from
Georg Brandl <georg@python.org>
parents:
49351
diff
changeset
|
581 return -1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
582 memcpy(p, (char *)&x, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
583 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
584 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
585 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
586 #ifdef HAVE_LONG_LONG |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
587 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
588 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
589 np_longlong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
590 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
591 PY_LONG_LONG x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
592 if (get_longlong(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
593 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
594 memcpy(p, (char *)&x, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
595 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
596 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
597 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
598 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
599 np_ulonglong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
600 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
601 unsigned PY_LONG_LONG x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
602 if (get_ulonglong(v, &x) < 0) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
603 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
604 memcpy(p, (char *)&x, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
605 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
606 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
607 #endif |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
608 |
|
40681
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
609 |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
610 static int |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
611 np_bool(char *p, PyObject *v, const formatdef *f) |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
612 { |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
613 BOOL_TYPE y; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
614 y = PyObject_IsTrue(v); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
615 memcpy(p, (char *)&y, sizeof y); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
616 return 0; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
617 } |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
618 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
619 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
620 np_float(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
621 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
622 float x = (float)PyFloat_AsDouble(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
623 if (x == -1 && PyErr_Occurred()) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
624 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
625 "required argument is not a float"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
626 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
627 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
628 memcpy(p, (char *)&x, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
629 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
630 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
631 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
632 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
633 np_double(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
634 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
635 double x = PyFloat_AsDouble(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
636 if (x == -1 && PyErr_Occurred()) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
637 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
638 "required argument is not a float"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
639 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
640 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
641 memcpy(p, (char *)&x, sizeof(double)); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
642 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
643 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
644 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
645 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
646 np_void_p(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
647 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
648 void *x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
649 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
650 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
651 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
652 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
653 assert(PyLong_Check(v)); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
654 x = PyLong_AsVoidPtr(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
655 Py_DECREF(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
656 if (x == NULL && PyErr_Occurred()) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
657 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
658 memcpy(p, (char *)&x, sizeof x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
659 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
660 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
661 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
662 static formatdef native_table[] = { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
663 {'x', sizeof(char), 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
664 {'b', sizeof(char), 0, nu_byte, np_byte}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
665 {'B', sizeof(char), 0, nu_ubyte, np_ubyte}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
666 {'c', sizeof(char), 0, nu_char, np_char}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
667 {'s', sizeof(char), 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
668 {'p', sizeof(char), 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
669 {'h', sizeof(short), SHORT_ALIGN, nu_short, np_short}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
670 {'H', sizeof(short), SHORT_ALIGN, nu_ushort, np_ushort}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
671 {'i', sizeof(int), INT_ALIGN, nu_int, np_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
672 {'I', sizeof(int), INT_ALIGN, nu_uint, np_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
673 {'l', sizeof(long), LONG_ALIGN, nu_long, np_long}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
674 {'L', sizeof(long), LONG_ALIGN, nu_ulong, np_ulong}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
675 #ifdef HAVE_LONG_LONG |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
676 {'q', sizeof(PY_LONG_LONG), LONG_LONG_ALIGN, nu_longlong, np_longlong}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
677 {'Q', sizeof(PY_LONG_LONG), LONG_LONG_ALIGN, nu_ulonglong,np_ulonglong}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
678 #endif |
|
45672
d41a4206405c
Issue 1872: Changed the struct module typecode from 't' to '?', for
Thomas Heller <theller@ctypes.org>
parents:
45373
diff
changeset
|
679 {'?', sizeof(BOOL_TYPE), BOOL_ALIGN, nu_bool, np_bool}, |
|
38317
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
680 {'f', sizeof(float), FLOAT_ALIGN, nu_float, np_float}, |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
681 {'d', sizeof(double), DOUBLE_ALIGN, nu_double, np_double}, |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
682 {'P', sizeof(void *), VOID_P_ALIGN, nu_void_p, np_void_p}, |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
683 {0} |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
684 }; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
685 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
686 /* Big-endian routines. *****************************************************/ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
687 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
688 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
689 bu_int(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
690 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
691 long x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
692 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
693 const unsigned char *bytes = (const unsigned char *)p; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
694 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
695 x = (x<<8) | *bytes++; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
696 } while (--i > 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
697 /* Extend the sign bit. */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
698 if (SIZEOF_LONG > f->size) |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
699 x |= -(x & (1L << ((8 * f->size) - 1))); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
700 return PyInt_FromLong(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
701 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
702 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
703 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
704 bu_uint(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
705 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
706 unsigned long x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
707 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
708 const unsigned char *bytes = (const unsigned char *)p; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
709 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
710 x = (x<<8) | *bytes++; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
711 } while (--i > 0); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
712 if (x <= LONG_MAX) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
713 return PyInt_FromLong((long)x); |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
714 return PyLong_FromUnsignedLong(x); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
715 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
716 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
717 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
718 bu_longlong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
719 { |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
720 #ifdef HAVE_LONG_LONG |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
721 PY_LONG_LONG x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
722 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
723 const unsigned char *bytes = (const unsigned char *)p; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
724 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
725 x = (x<<8) | *bytes++; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
726 } while (--i > 0); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
727 /* Extend the sign bit. */ |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
728 if (SIZEOF_LONG_LONG > f->size) |
|
41526
708c8c5fc173
Make pythoncore compile cleanly with VisualStudio 2005. Used an explicit typecast to get a 64 bit integer, and undefined the Yield macro that conflicts with winbase.h
Kristján Valur Jónsson <kristjan@ccpgames.com>
parents:
41391
diff
changeset
|
729 x |= -(x & ((PY_LONG_LONG)1 << ((8 * f->size) - 1))); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
730 if (x >= LONG_MIN && x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
731 return PyInt_FromLong(Py_SAFE_DOWNCAST(x, PY_LONG_LONG, long)); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
732 return PyLong_FromLongLong(x); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
733 #else |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
734 return _PyLong_FromByteArray((const unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
735 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
736 0, /* little-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
737 1 /* signed */); |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
738 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
739 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
740 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
741 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
742 bu_ulonglong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
743 { |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
744 #ifdef HAVE_LONG_LONG |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
745 unsigned PY_LONG_LONG x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
746 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
747 const unsigned char *bytes = (const unsigned char *)p; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
748 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
749 x = (x<<8) | *bytes++; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
750 } while (--i > 0); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
751 if (x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
752 return PyInt_FromLong(Py_SAFE_DOWNCAST(x, unsigned PY_LONG_LONG, long)); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
753 return PyLong_FromUnsignedLongLong(x); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
754 #else |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
755 return _PyLong_FromByteArray((const unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
756 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
757 0, /* little-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
758 0 /* signed */); |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
759 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
760 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
761 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
762 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
763 bu_float(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
764 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
765 return unpack_float(p, 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
766 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
767 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
768 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
769 bu_double(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
770 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
771 return unpack_double(p, 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
772 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
773 |
|
40681
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
774 static PyObject * |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
775 bu_bool(const char *p, const formatdef *f) |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
776 { |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
777 char x; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
778 memcpy((char *)&x, p, sizeof x); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
779 return PyBool_FromLong(x != 0); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
780 } |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
781 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
782 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
783 bp_int(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
784 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
785 long x; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
786 Py_ssize_t i; |
|
56246
3dec3b77b787
Eliminate unnecessary get_wrapped_(u)long defines in struct module.
Mark Dickinson <dickinsm@gmail.com>
parents:
55153
diff
changeset
|
787 if (get_long(v, &x) < 0) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
788 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
789 i = f->size; |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
790 if (i != SIZEOF_LONG) { |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
791 if ((i == 2) && (x < -32768 || x > 32767)) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
792 return _range_error(f, 0); |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
793 #if (SIZEOF_LONG != 4) |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
794 else if ((i == 4) && (x < -2147483648L || x > 2147483647L)) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
795 return _range_error(f, 0); |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
796 #endif |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
797 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
798 do { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
799 p[--i] = (char)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
800 x >>= 8; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
801 } while (i > 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
802 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
803 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
804 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
805 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
806 bp_uint(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
807 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
808 unsigned long x; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
809 Py_ssize_t i; |
|
56246
3dec3b77b787
Eliminate unnecessary get_wrapped_(u)long defines in struct module.
Mark Dickinson <dickinsm@gmail.com>
parents:
55153
diff
changeset
|
810 if (get_ulong(v, &x) < 0) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
811 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
812 i = f->size; |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
813 if (i != SIZEOF_LONG) { |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
814 unsigned long maxint = 1; |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
815 maxint <<= (unsigned long)(i * 8); |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
816 if (x >= maxint) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
817 return _range_error(f, 1); |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
818 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
819 do { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
820 p[--i] = (char)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
821 x >>= 8; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
822 } while (i > 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
823 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
824 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
825 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
826 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
827 bp_longlong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
828 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
829 int res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
830 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
831 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
832 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
833 res = _PyLong_AsByteArray((PyLongObject *)v, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
834 (unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
835 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
836 0, /* little_endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
837 1 /* signed */); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
838 Py_DECREF(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
839 return res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
840 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
841 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
842 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
843 bp_ulonglong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
844 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
845 int res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
846 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
847 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
848 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
849 res = _PyLong_AsByteArray((PyLongObject *)v, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
850 (unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
851 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
852 0, /* little_endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
853 0 /* signed */); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
854 Py_DECREF(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
855 return res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
856 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
857 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
858 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
859 bp_float(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
860 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
861 double x = PyFloat_AsDouble(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
862 if (x == -1 && PyErr_Occurred()) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
863 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
864 "required argument is not a float"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
865 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
866 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
867 return _PyFloat_Pack4(x, (unsigned char *)p, 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
868 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
869 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
870 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
871 bp_double(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
872 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
873 double x = PyFloat_AsDouble(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
874 if (x == -1 && PyErr_Occurred()) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
875 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
876 "required argument is not a float"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
877 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
878 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
879 return _PyFloat_Pack8(x, (unsigned char *)p, 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
880 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
881 |
|
40681
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
882 static int |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
883 bp_bool(char *p, PyObject *v, const formatdef *f) |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
884 { |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
885 char y; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
886 y = PyObject_IsTrue(v); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
887 memcpy(p, (char *)&y, sizeof y); |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
888 return 0; |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
889 } |
|
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
890 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
891 static formatdef bigendian_table[] = { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
892 {'x', 1, 0, NULL}, |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
893 {'b', 1, 0, nu_byte, np_byte}, |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
894 {'B', 1, 0, nu_ubyte, np_ubyte}, |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
895 {'c', 1, 0, nu_char, np_char}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
896 {'s', 1, 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
897 {'p', 1, 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
898 {'h', 2, 0, bu_int, bp_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
899 {'H', 2, 0, bu_uint, bp_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
900 {'i', 4, 0, bu_int, bp_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
901 {'I', 4, 0, bu_uint, bp_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
902 {'l', 4, 0, bu_int, bp_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
903 {'L', 4, 0, bu_uint, bp_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
904 {'q', 8, 0, bu_longlong, bp_longlong}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
905 {'Q', 8, 0, bu_ulonglong, bp_ulonglong}, |
|
45672
d41a4206405c
Issue 1872: Changed the struct module typecode from 't' to '?', for
Thomas Heller <theller@ctypes.org>
parents:
45373
diff
changeset
|
906 {'?', 1, 0, bu_bool, bp_bool}, |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
907 {'f', 4, 0, bu_float, bp_float}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
908 {'d', 8, 0, bu_double, bp_double}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
909 {0} |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
910 }; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
911 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
912 /* Little-endian routines. *****************************************************/ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
913 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
914 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
915 lu_int(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
916 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
917 long x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
918 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
919 const unsigned char *bytes = (const unsigned char *)p; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
920 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
921 x = (x<<8) | bytes[--i]; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
922 } while (i > 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
923 /* Extend the sign bit. */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
924 if (SIZEOF_LONG > f->size) |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
925 x |= -(x & (1L << ((8 * f->size) - 1))); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
926 return PyInt_FromLong(x); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
927 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
928 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
929 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
930 lu_uint(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
931 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
932 unsigned long x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
933 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
934 const unsigned char *bytes = (const unsigned char *)p; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
935 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
936 x = (x<<8) | bytes[--i]; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
937 } while (i > 0); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
938 if (x <= LONG_MAX) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
939 return PyInt_FromLong((long)x); |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
940 return PyLong_FromUnsignedLong((long)x); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
941 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
942 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
943 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
944 lu_longlong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
945 { |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
946 #ifdef HAVE_LONG_LONG |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
947 PY_LONG_LONG x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
948 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
949 const unsigned char *bytes = (const unsigned char *)p; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
950 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
951 x = (x<<8) | bytes[--i]; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
952 } while (i > 0); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
953 /* Extend the sign bit. */ |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
954 if (SIZEOF_LONG_LONG > f->size) |
|
41526
708c8c5fc173
Make pythoncore compile cleanly with VisualStudio 2005. Used an explicit typecast to get a 64 bit integer, and undefined the Yield macro that conflicts with winbase.h
Kristján Valur Jónsson <kristjan@ccpgames.com>
parents:
41391
diff
changeset
|
955 x |= -(x & ((PY_LONG_LONG)1 << ((8 * f->size) - 1))); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
956 if (x >= LONG_MIN && x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
957 return PyInt_FromLong(Py_SAFE_DOWNCAST(x, PY_LONG_LONG, long)); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
958 return PyLong_FromLongLong(x); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
959 #else |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
960 return _PyLong_FromByteArray((const unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
961 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
962 1, /* little-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
963 1 /* signed */); |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
964 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
965 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
966 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
967 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
968 lu_ulonglong(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
969 { |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
970 #ifdef HAVE_LONG_LONG |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
971 unsigned PY_LONG_LONG x = 0; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
972 Py_ssize_t i = f->size; |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
973 const unsigned char *bytes = (const unsigned char *)p; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
974 do { |
|
38483
fb56a3992604
simplify the struct code a bit (no functional changes)
Bob Ippolito <bob@redivi.com>
parents:
38470
diff
changeset
|
975 x = (x<<8) | bytes[--i]; |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
976 } while (i > 0); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
977 if (x <= LONG_MAX) |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
978 return PyInt_FromLong(Py_SAFE_DOWNCAST(x, unsigned PY_LONG_LONG, long)); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
979 return PyLong_FromUnsignedLongLong(x); |
|
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
980 #else |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
981 return _PyLong_FromByteArray((const unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
982 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
983 1, /* little-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
984 0 /* signed */); |
|
38310
850d4f7717b8
Struct now unpacks to PY_LONG_LONG directly when possible, also include #ifdef'ed out code that will return int instead of long when in bounds (not active since it's an API and doc change)
Bob Ippolito <bob@redivi.com>
parents:
38277
diff
changeset
|
985 #endif |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
986 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
987 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
988 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
989 lu_float(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
990 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
991 return unpack_float(p, 1); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
992 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
993 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
994 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
995 lu_double(const char *p, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
996 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
997 return unpack_double(p, 1); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
998 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
999 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1000 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1001 lp_int(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1002 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1003 long x; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1004 Py_ssize_t i; |
|
56246
3dec3b77b787
Eliminate unnecessary get_wrapped_(u)long defines in struct module.
Mark Dickinson <dickinsm@gmail.com>
parents:
55153
diff
changeset
|
1005 if (get_long(v, &x) < 0) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1006 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1007 i = f->size; |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1008 if (i != SIZEOF_LONG) { |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1009 if ((i == 2) && (x < -32768 || x > 32767)) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1010 return _range_error(f, 0); |
|
38429
003433511e4d
Remove the range checking and int usage #defines from _struct and strip out the now-dead code
Bob Ippolito <bob@redivi.com>
parents:
38411
diff
changeset
|
1011 #if (SIZEOF_LONG != 4) |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1012 else if ((i == 4) && (x < -2147483648L || x > 2147483647L)) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1013 return _range_error(f, 0); |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
1014 #endif |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1015 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1016 do { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1017 *p++ = (char)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1018 x >>= 8; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1019 } while (--i > 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1020 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1021 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1022 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1023 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1024 lp_uint(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1025 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1026 unsigned long x; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1027 Py_ssize_t i; |
|
56246
3dec3b77b787
Eliminate unnecessary get_wrapped_(u)long defines in struct module.
Mark Dickinson <dickinsm@gmail.com>
parents:
55153
diff
changeset
|
1028 if (get_ulong(v, &x) < 0) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1029 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1030 i = f->size; |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1031 if (i != SIZEOF_LONG) { |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1032 unsigned long maxint = 1; |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1033 maxint <<= (unsigned long)(i * 8); |
|
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1034 if (x >= maxint) |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1035 return _range_error(f, 1); |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1036 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1037 do { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1038 *p++ = (char)x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1039 x >>= 8; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1040 } while (--i > 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1041 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1042 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1043 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1044 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1045 lp_longlong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1046 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1047 int res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1048 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1049 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1050 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1051 res = _PyLong_AsByteArray((PyLongObject*)v, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1052 (unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1053 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1054 1, /* little_endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1055 1 /* signed */); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1056 Py_DECREF(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1057 return res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1058 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1059 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1060 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1061 lp_ulonglong(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1062 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1063 int res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1064 v = get_pylong(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1065 if (v == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1066 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1067 res = _PyLong_AsByteArray((PyLongObject*)v, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1068 (unsigned char *)p, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1069 8, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1070 1, /* little_endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1071 0 /* signed */); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1072 Py_DECREF(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1073 return res; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1074 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1075 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1076 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1077 lp_float(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1078 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1079 double x = PyFloat_AsDouble(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1080 if (x == -1 && PyErr_Occurred()) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1081 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1082 "required argument is not a float"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1083 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1084 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1085 return _PyFloat_Pack4(x, (unsigned char *)p, 1); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1086 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1087 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1088 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1089 lp_double(char *p, PyObject *v, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1090 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1091 double x = PyFloat_AsDouble(v); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1092 if (x == -1 && PyErr_Occurred()) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1093 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1094 "required argument is not a float"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1095 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1096 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1097 return _PyFloat_Pack8(x, (unsigned char *)p, 1); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1098 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1099 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1100 static formatdef lilendian_table[] = { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1101 {'x', 1, 0, NULL}, |
|
38363
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
1102 {'b', 1, 0, nu_byte, np_byte}, |
|
5213b6065197
fix #1229380 No struct.pack exception for some out of range integers
Bob Ippolito <bob@redivi.com>
parents:
38353
diff
changeset
|
1103 {'B', 1, 0, nu_ubyte, np_ubyte}, |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1104 {'c', 1, 0, nu_char, np_char}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1105 {'s', 1, 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1106 {'p', 1, 0, NULL}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1107 {'h', 2, 0, lu_int, lp_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1108 {'H', 2, 0, lu_uint, lp_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1109 {'i', 4, 0, lu_int, lp_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1110 {'I', 4, 0, lu_uint, lp_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1111 {'l', 4, 0, lu_int, lp_int}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1112 {'L', 4, 0, lu_uint, lp_uint}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1113 {'q', 8, 0, lu_longlong, lp_longlong}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1114 {'Q', 8, 0, lu_ulonglong, lp_ulonglong}, |
|
45672
d41a4206405c
Issue 1872: Changed the struct module typecode from 't' to '?', for
Thomas Heller <theller@ctypes.org>
parents:
45373
diff
changeset
|
1115 {'?', 1, 0, bu_bool, bp_bool}, /* Std rep not endian dep, |
|
40681
0bffca64ccc4
Patch #1610575: Add support for _Bool to struct.
Martin v. Löwis <martin@v.loewis.de>
parents:
39380
diff
changeset
|
1116 but potentially different from native rep -- reuse bx_bool funcs. */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1117 {'f', 4, 0, lu_float, lp_float}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1118 {'d', 8, 0, lu_double, lp_double}, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1119 {0} |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1120 }; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1121 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1122 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1123 static const formatdef * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1124 whichtable(char **pfmt) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1125 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1126 const char *fmt = (*pfmt)++; /* May be backed out of later */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1127 switch (*fmt) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1128 case '<': |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1129 return lilendian_table; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1130 case '>': |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1131 case '!': /* Network byte order is big-endian */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1132 return bigendian_table; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1133 case '=': { /* Host byte order -- different from native in aligment! */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1134 int n = 1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1135 char *p = (char *) &n; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1136 if (*p == 1) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1137 return lilendian_table; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1138 else |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1139 return bigendian_table; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1140 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1141 default: |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1142 --*pfmt; /* Back out of pointer increment */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1143 /* Fall through */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1144 case '@': |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1145 return native_table; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1146 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1147 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1148 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1149 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1150 /* Get the table entry for a format code */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1151 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1152 static const formatdef * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1153 getentry(int c, const formatdef *f) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1154 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1155 for (; f->format != '\0'; f++) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1156 if (f->format == c) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1157 return f; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1158 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1159 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1160 PyErr_SetString(StructError, "bad char in struct format"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1161 return NULL; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1162 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1163 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1164 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1165 /* Align a size according to a format code */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1166 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1167 static int |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1168 align(Py_ssize_t size, char c, const formatdef *e) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1169 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1170 if (e->format == c) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1171 if (e->alignment) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1172 size = ((size + e->alignment - 1) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1173 / e->alignment) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1174 * e->alignment; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1175 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1176 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1177 return size; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1178 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1179 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1180 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1181 /* calculate the size of a format string */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1182 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1183 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1184 prepare_s(PyStructObject *self) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1185 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1186 const formatdef *f; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1187 const formatdef *e; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1188 formatcode *codes; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1189 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1190 const char *s; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1191 const char *fmt; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1192 char c; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1193 Py_ssize_t size, len, num, itemsize, x; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1194 |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1195 fmt = PyString_AS_STRING(self->s_format); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1196 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1197 f = whichtable((char **)&fmt); |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1198 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1199 s = fmt; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1200 size = 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1201 len = 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1202 while ((c = *s++) != '\0') { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1203 if (isspace(Py_CHARMASK(c))) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1204 continue; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1205 if ('0' <= c && c <= '9') { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1206 num = c - '0'; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1207 while ('0' <= (c = *s++) && c <= '9') { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1208 x = num*10 + (c - '0'); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1209 if (x/10 != num) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1210 PyErr_SetString( |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1211 StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1212 "overflow in item count"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1213 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1214 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1215 num = x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1216 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1217 if (c == '\0') |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1218 break; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1219 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1220 else |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1221 num = 1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1222 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1223 e = getentry(c, f); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1224 if (e == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1225 return -1; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1226 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1227 switch (c) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1228 case 's': /* fall through */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1229 case 'p': len++; break; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1230 case 'x': break; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1231 default: len += num; break; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1232 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1233 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1234 itemsize = e->size; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1235 size = align(size, c, e); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1236 x = num * itemsize; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1237 size += x; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1238 if (x/itemsize != num || size < 0) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1239 PyErr_SetString(StructError, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1240 "total struct size too long"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1241 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1242 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1243 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1244 |
|
47587
1c964ed35ef9
Merge in release25-maint r60793:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47527
diff
changeset
|
1245 /* check for overflow */ |
|
1c964ed35ef9
Merge in release25-maint r60793:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47527
diff
changeset
|
1246 if ((len + 1) > (PY_SSIZE_T_MAX / sizeof(formatcode))) { |
|
1c964ed35ef9
Merge in release25-maint r60793:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47527
diff
changeset
|
1247 PyErr_NoMemory(); |
|
1c964ed35ef9
Merge in release25-maint r60793:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47527
diff
changeset
|
1248 return -1; |
|
1c964ed35ef9
Merge in release25-maint r60793:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47527
diff
changeset
|
1249 } |
|
1c964ed35ef9
Merge in release25-maint r60793:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47527
diff
changeset
|
1250 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1251 self->s_size = size; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1252 self->s_len = len; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1253 codes = PyMem_MALLOC((len + 1) * sizeof(formatcode)); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1254 if (codes == NULL) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1255 PyErr_NoMemory(); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1256 return -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1257 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1258 self->s_codes = codes; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1259 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1260 s = fmt; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1261 size = 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1262 while ((c = *s++) != '\0') { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1263 if (isspace(Py_CHARMASK(c))) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1264 continue; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1265 if ('0' <= c && c <= '9') { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1266 num = c - '0'; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1267 while ('0' <= (c = *s++) && c <= '9') |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1268 num = num*10 + (c - '0'); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1269 if (c == '\0') |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1270 break; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1271 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1272 else |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1273 num = 1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1274 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1275 e = getentry(c, f); |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1276 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1277 size = align(size, c, e); |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1278 if (c == 's' || c == 'p') { |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1279 codes->offset = size; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1280 codes->size = num; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1281 codes->fmtdef = e; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1282 codes++; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1283 size += num; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1284 } else if (c == 'x') { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1285 size += num; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1286 } else { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1287 while (--num >= 0) { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1288 codes->offset = size; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1289 codes->size = e->size; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1290 codes->fmtdef = e; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1291 codes++; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1292 size += e->size; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1293 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1294 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1295 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1296 codes->fmtdef = NULL; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1297 codes->offset = size; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1298 codes->size = 0; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1299 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1300 return 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1301 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1302 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1303 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1304 s_new(PyTypeObject *type, PyObject *args, PyObject *kwds) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1305 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1306 PyObject *self; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1307 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1308 assert(type != NULL && type->tp_alloc != NULL); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1309 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1310 self = type->tp_alloc(type, 0); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1311 if (self != NULL) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1312 PyStructObject *s = (PyStructObject*)self; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1313 Py_INCREF(Py_None); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1314 s->s_format = Py_None; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1315 s->s_codes = NULL; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1316 s->s_size = -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1317 s->s_len = -1; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1318 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1319 return self; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1320 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1321 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1322 static int |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1323 s_init(PyObject *self, PyObject *args, PyObject *kwds) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1324 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1325 PyStructObject *soself = (PyStructObject *)self; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1326 PyObject *o_format = NULL; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1327 int ret = 0; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1328 static char *kwlist[] = {"format", 0}; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1329 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1330 assert(PyStruct_Check(self)); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1331 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1332 if (!PyArg_ParseTupleAndKeywords(args, kwds, "S:Struct", kwlist, |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1333 &o_format)) |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1334 return -1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1335 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1336 Py_INCREF(o_format); |
|
45373
f378edd21df2
Crashers of the day: Py_CLEAR must be used when there is a chance that the
Amaury Forgeot d'Arc <amauryfa@gmail.com>
parents:
44733
diff
changeset
|
1337 Py_CLEAR(soself->s_format); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1338 soself->s_format = o_format; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1339 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1340 ret = prepare_s(soself); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1341 return ret; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1342 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1343 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1344 static void |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1345 s_dealloc(PyStructObject *s) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1346 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1347 if (s->weakreflist != NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1348 PyObject_ClearWeakRefs((PyObject *)s); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1349 if (s->s_codes != NULL) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1350 PyMem_FREE(s->s_codes); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1351 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1352 Py_XDECREF(s->s_format); |
|
44350
26384b8180c7
#1629: Renamed Py_Size, Py_Type and Py_Refcnt to Py_SIZE, Py_TYPE and Py_REFCNT. Macros for b/w compatibility are available.
Christian Heimes <christian@cheimes.de>
parents:
42333
diff
changeset
|
1353 Py_TYPE(s)->tp_free((PyObject *)s); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1354 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1355 |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1356 static PyObject * |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1357 s_unpack_internal(PyStructObject *soself, char *startfrom) { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1358 formatcode *code; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1359 Py_ssize_t i = 0; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1360 PyObject *result = PyTuple_New(soself->s_len); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1361 if (result == NULL) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1362 return NULL; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1363 |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1364 for (code = soself->s_codes; code->fmtdef != NULL; code++) { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1365 PyObject *v; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1366 const formatdef *e = code->fmtdef; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1367 const char *res = startfrom + code->offset; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1368 if (e->format == 's') { |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1369 v = PyString_FromStringAndSize(res, code->size); |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1370 } else if (e->format == 'p') { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1371 Py_ssize_t n = *(unsigned char*)res; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1372 if (n >= code->size) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1373 n = code->size - 1; |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1374 v = PyString_FromStringAndSize(res + 1, n); |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1375 } else { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1376 v = e->unpack(res, e); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1377 } |
| 38736 | 1378 if (v == NULL) |
| 1379 goto fail; | |
| 1380 PyTuple_SET_ITEM(result, i++, v); | |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1381 } |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1382 |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1383 return result; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1384 fail: |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1385 Py_DECREF(result); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1386 return NULL; |
|
38445
8daeb9af8422
fix struct regression on 64-bit platforms
Bob Ippolito <bob@redivi.com>
parents:
38430
diff
changeset
|
1387 } |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1388 |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1389 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1390 PyDoc_STRVAR(s_unpack__doc__, |
|
38430
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1391 "S.unpack(str) -> (v1, v2, ...)\n\ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1392 \n\ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1393 Return tuple containing values unpacked according to this Struct's format.\n\ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1394 Requires len(str) == self.size. See struct.__doc__ for more on format\n\ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1395 strings."); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1396 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1397 static PyObject * |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1398 s_unpack(PyObject *self, PyObject *inputstr) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1399 { |
|
41391
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1400 char *start; |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1401 Py_ssize_t len; |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1402 PyObject *args=NULL, *result; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1403 PyStructObject *soself = (PyStructObject *)self; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1404 assert(PyStruct_Check(self)); |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1405 assert(soself->s_codes != NULL); |
|
41391
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1406 if (inputstr == NULL) |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1407 goto fail; |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1408 if (PyString_Check(inputstr) && |
|
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1409 PyString_GET_SIZE(inputstr) == soself->s_size) { |
|
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1410 return s_unpack_internal(soself, PyString_AS_STRING(inputstr)); |
|
41391
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1411 } |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1412 args = PyTuple_Pack(1, inputstr); |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1413 if (args == NULL) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1414 return NULL; |
|
41391
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1415 if (!PyArg_ParseTuple(args, "s#:unpack", &start, &len)) |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1416 goto fail; |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1417 if (soself->s_size != len) |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1418 goto fail; |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1419 result = s_unpack_internal(soself, start); |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1420 Py_DECREF(args); |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1421 return result; |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1422 |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1423 fail: |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1424 Py_XDECREF(args); |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1425 PyErr_Format(StructError, |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1426 "unpack requires a string argument of length %zd", |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1427 soself->s_size); |
|
80ff75fa2754
Bug #1563759: struct.unpack doens't support buffer protocol objects
Raymond Hettinger <python@rcn.com>
parents:
40681
diff
changeset
|
1428 return NULL; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1429 } |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1430 |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1431 PyDoc_STRVAR(s_unpack_from__doc__, |
|
38430
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1432 "S.unpack_from(buffer[, offset]) -> (v1, v2, ...)\n\ |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1433 \n\ |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1434 Return tuple containing values unpacked according to this Struct's format.\n\ |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1435 Unlike unpack, unpack_from can unpack values from any object supporting\n\ |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1436 the buffer API, not just str. Requires len(buffer[offset:]) >= self.size.\n\ |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1437 See struct.__doc__ for more on format strings."); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1438 |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1439 static PyObject * |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1440 s_unpack_from(PyObject *self, PyObject *args, PyObject *kwds) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1441 { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1442 static char *kwlist[] = {"buffer", "offset", 0}; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1443 #if (PY_VERSION_HEX < 0x02050000) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1444 static char *fmt = "z#|i:unpack_from"; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1445 #else |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1446 static char *fmt = "z#|n:unpack_from"; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1447 #endif |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1448 Py_ssize_t buffer_len = 0, offset = 0; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1449 char *buffer = NULL; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1450 PyStructObject *soself = (PyStructObject *)self; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1451 assert(PyStruct_Check(self)); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1452 assert(soself->s_codes != NULL); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1453 |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1454 if (!PyArg_ParseTupleAndKeywords(args, kwds, fmt, kwlist, |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1455 &buffer, &buffer_len, &offset)) |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1456 return NULL; |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1457 |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1458 if (buffer == NULL) { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1459 PyErr_Format(StructError, |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1460 "unpack_from requires a buffer argument"); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1461 return NULL; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1462 } |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1463 |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1464 if (offset < 0) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1465 offset += buffer_len; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1466 |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1467 if (offset < 0 || (buffer_len - offset) < soself->s_size) { |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1468 PyErr_Format(StructError, |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1469 "unpack_from requires a buffer of at least %zd bytes", |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1470 soself->s_size); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1471 return NULL; |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1472 } |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1473 return s_unpack_internal(soself, buffer + offset); |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1474 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1475 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1476 |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1477 /* |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1478 * Guts of the pack function. |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1479 * |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1480 * Takes a struct object, a tuple of arguments, and offset in that tuple of |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1481 * argument for where to start processing the arguments for packing, and a |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1482 * character buffer for writing the packed string. The caller must insure |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1483 * that the buffer may contain the required length for packing the arguments. |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1484 * 0 is returned on success, 1 is returned if there is an error. |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1485 * |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1486 */ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1487 static int |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1488 s_pack_internal(PyStructObject *soself, PyObject *args, int offset, char* buf) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1489 { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1490 formatcode *code; |
| 38736 | 1491 /* XXX(nnorwitz): why does i need to be a local? can we use |
| 1492 the offset parameter or do we need the wider width? */ | |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1493 Py_ssize_t i; |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1494 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1495 memset(buf, '\0', soself->s_size); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1496 i = offset; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1497 for (code = soself->s_codes; code->fmtdef != NULL; code++) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1498 Py_ssize_t n; |
| 38736 | 1499 PyObject *v = PyTuple_GET_ITEM(args, i++); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1500 const formatdef *e = code->fmtdef; |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1501 char *res = buf + code->offset; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1502 if (e->format == 's') { |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1503 if (!PyString_Check(v)) { |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1504 PyErr_SetString(StructError, |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1505 "argument for 's' must " |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1506 "be a string"); |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1507 return -1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1508 } |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1509 n = PyString_GET_SIZE(v); |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1510 if (n > code->size) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1511 n = code->size; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1512 if (n > 0) |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1513 memcpy(res, PyString_AS_STRING(v), n); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1514 } else if (e->format == 'p') { |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1515 if (!PyString_Check(v)) { |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1516 PyErr_SetString(StructError, |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1517 "argument for 'p' must " |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1518 "be a string"); |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1519 return -1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1520 } |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1521 n = PyString_GET_SIZE(v); |
|
38277
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1522 if (n > (code->size - 1)) |
|
b825e6227366
refactor unpack, add unpack_from
Bob Ippolito <bob@redivi.com>
parents:
38267
diff
changeset
|
1523 n = code->size - 1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1524 if (n > 0) |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1525 memcpy(res + 1, PyString_AS_STRING(v), n); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1526 if (n > 255) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1527 n = 255; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1528 *res = Py_SAFE_DOWNCAST(n, Py_ssize_t, unsigned char); |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1529 } else if (e->pack(res, v, e) < 0) { |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1530 if (strchr(integer_codes, e->format) != NULL && |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1531 PyErr_ExceptionMatches(PyExc_OverflowError)) |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1532 PyErr_Format(StructError, |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1533 "integer out of range for " |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1534 "'%c' format code", |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1535 e->format); |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1536 return -1; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1537 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1538 } |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1539 |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1540 /* Success */ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1541 return 0; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1542 } |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1543 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1544 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1545 PyDoc_STRVAR(s_pack__doc__, |
|
38430
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1546 "S.pack(v1, v2, ...) -> string\n\ |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1547 \n\ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1548 Return a string containing values v1, v2, ... packed according to this\n\ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1549 Struct's format. See struct.__doc__ for more on format strings."); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1550 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1551 static PyObject * |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1552 s_pack(PyObject *self, PyObject *args) |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1553 { |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1554 PyStructObject *soself; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1555 PyObject *result; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1556 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1557 /* Validate arguments. */ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1558 soself = (PyStructObject *)self; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1559 assert(PyStruct_Check(self)); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1560 assert(soself->s_codes != NULL); |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1561 if (PyTuple_GET_SIZE(args) != soself->s_len) |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1562 { |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1563 PyErr_Format(StructError, |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1564 "pack requires exactly %zd arguments", soself->s_len); |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1565 return NULL; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1566 } |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1567 |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1568 /* Allocate a new string */ |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1569 result = PyString_FromStringAndSize((char *)NULL, soself->s_size); |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1570 if (result == NULL) |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1571 return NULL; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1572 |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1573 /* Call the guts */ |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1574 if ( s_pack_internal(soself, args, 0, PyString_AS_STRING(result)) != 0 ) { |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1575 Py_DECREF(result); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1576 return NULL; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1577 } |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1578 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1579 return result; |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1580 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1581 |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1582 PyDoc_STRVAR(s_pack_into__doc__, |
|
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1583 "S.pack_into(buffer, offset, v1, v2, ...)\n\ |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1584 \n\ |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1585 Pack the values v1, v2, ... according to this Struct's format, write \n\ |
|
38430
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1586 the packed bytes into the writable buffer buf starting at offset. Note\n\ |
|
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1587 that the offset is not an optional argument. See struct.__doc__ for \n\ |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1588 more on format strings."); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1589 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1590 static PyObject * |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1591 s_pack_into(PyObject *self, PyObject *args) |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1592 { |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1593 PyStructObject *soself; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1594 char *buffer; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1595 Py_ssize_t buffer_len, offset; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1596 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1597 /* Validate arguments. +1 is for the first arg as buffer. */ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1598 soself = (PyStructObject *)self; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1599 assert(PyStruct_Check(self)); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1600 assert(soself->s_codes != NULL); |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1601 if (PyTuple_GET_SIZE(args) != (soself->s_len + 2)) |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1602 { |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1603 PyErr_Format(StructError, |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1604 "pack_into requires exactly %zd arguments", |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1605 (soself->s_len + 2)); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1606 return NULL; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1607 } |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1608 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1609 /* Extract a writable memory buffer from the first argument */ |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1610 if ( PyObject_AsWriteBuffer(PyTuple_GET_ITEM(args, 0), |
|
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1611 (void**)&buffer, &buffer_len) == -1 ) { |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1612 return NULL; |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1613 } |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1614 assert( buffer_len >= 0 ); |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1615 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1616 /* Extract the offset from the first argument */ |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1617 offset = PyInt_AsSsize_t(PyTuple_GET_ITEM(args, 1)); |
|
49351
6a73134f9603
Victor Stinner's patches to check the return result of PyLong_Ssize_t
Benjamin Peterson <benjamin@python.org>
parents:
47587
diff
changeset
|
1618 if (offset == -1 && PyErr_Occurred()) |
|
6a73134f9603
Victor Stinner's patches to check the return result of PyLong_Ssize_t
Benjamin Peterson <benjamin@python.org>
parents:
47587
diff
changeset
|
1619 return NULL; |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1620 |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1621 /* Support negative offsets. */ |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1622 if (offset < 0) |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1623 offset += buffer_len; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1624 |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1625 /* Check boundaries */ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1626 if (offset < 0 || (buffer_len - offset) < soself->s_size) { |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1627 PyErr_Format(StructError, |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1628 "pack_into requires a buffer of at least %zd bytes", |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1629 soself->s_size); |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1630 return NULL; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1631 } |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1632 |
|
38353
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1633 /* Call the guts */ |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1634 if ( s_pack_internal(soself, args, 2, buffer + offset) != 0 ) { |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1635 return NULL; |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1636 } |
|
36cd4a4ab8f7
Support for buffer protocol for socket and struct.
Martin Blais <blais@furius.ca>
parents:
38322
diff
changeset
|
1637 |
|
38470
e0cea605417e
Fix ref-antileak in _struct.c which eventually lead to deallocating None.
Georg Brandl <georg@python.org>
parents:
38445
diff
changeset
|
1638 Py_RETURN_NONE; |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1639 } |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1640 |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1641 static PyObject * |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1642 s_get_format(PyStructObject *self, void *unused) |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1643 { |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1644 Py_INCREF(self->s_format); |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1645 return self->s_format; |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1646 } |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1647 |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1648 static PyObject * |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1649 s_get_size(PyStructObject *self, void *unused) |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1650 { |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1651 return PyInt_FromSsize_t(self->s_size); |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1652 } |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1653 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1654 /* List of functions */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1655 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1656 static struct PyMethodDef s_methods[] = { |
|
38580
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1657 {"pack", s_pack, METH_VARARGS, s_pack__doc__}, |
|
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1658 {"pack_into", s_pack_into, METH_VARARGS, s_pack_into__doc__}, |
|
a114003aa3d3
Fixes in struct and socket from merge reviews.
Martin Blais <blais@furius.ca>
parents:
38530
diff
changeset
|
1659 {"unpack", s_unpack, METH_O, s_unpack__doc__}, |
|
41816
ec83d21065aa
Stop using METH_OLDARGS implicitly
Neal Norwitz <nnorwitz@gmail.com>
parents:
41526
diff
changeset
|
1660 {"unpack_from", (PyCFunction)s_unpack_from, METH_VARARGS|METH_KEYWORDS, |
|
38583
e00e68dd1ddf
s_methods[]: Stop compiler warnings by casting
Tim Peters <tim.peters@gmail.com>
parents:
38580
diff
changeset
|
1661 s_unpack_from__doc__}, |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1662 {NULL, NULL} /* sentinel */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1663 }; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1664 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1665 PyDoc_STRVAR(s__doc__, "Compiled struct object"); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1666 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1667 #define OFF(x) offsetof(PyStructObject, x) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1668 |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1669 static PyGetSetDef s_getsetlist[] = { |
|
38430
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1670 {"format", (getter)s_get_format, (setter)NULL, "struct format string", NULL}, |
|
795d1cb1df01
Fix up struct docstrings, add struct.pack_to function for symmetry
Bob Ippolito <bob@redivi.com>
parents:
38429
diff
changeset
|
1671 {"size", (getter)s_get_size, (setter)NULL, "struct size in bytes", NULL}, |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1672 {NULL} /* sentinel */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1673 }; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1674 |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1675 static |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1676 PyTypeObject PyStructType = { |
|
42333
6620a510e9a9
PEP 3123: Provide forward compatibility with Python 3.0, while keeping
Martin v. Löwis <martin@v.loewis.de>
parents:
41816
diff
changeset
|
1677 PyVarObject_HEAD_INIT(NULL, 0) |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1678 "Struct", |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1679 sizeof(PyStructObject), |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1680 0, |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1681 (destructor)s_dealloc, /* tp_dealloc */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1682 0, /* tp_print */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1683 0, /* tp_getattr */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1684 0, /* tp_setattr */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1685 0, /* tp_compare */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1686 0, /* tp_repr */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1687 0, /* tp_as_number */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1688 0, /* tp_as_sequence */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1689 0, /* tp_as_mapping */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1690 0, /* tp_hash */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1691 0, /* tp_call */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1692 0, /* tp_str */ |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1693 PyObject_GenericGetAttr, /* tp_getattro */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1694 PyObject_GenericSetAttr, /* tp_setattro */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1695 0, /* tp_as_buffer */ |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1696 Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_WEAKREFS,/* tp_flags */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1697 s__doc__, /* tp_doc */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1698 0, /* tp_traverse */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1699 0, /* tp_clear */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1700 0, /* tp_richcompare */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1701 offsetof(PyStructObject, weakreflist), /* tp_weaklistoffset */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1702 0, /* tp_iter */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1703 0, /* tp_iternext */ |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1704 s_methods, /* tp_methods */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1705 NULL, /* tp_members */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1706 s_getsetlist, /* tp_getset */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1707 0, /* tp_base */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1708 0, /* tp_dict */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1709 0, /* tp_descr_get */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1710 0, /* tp_descr_set */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1711 0, /* tp_dictoffset */ |
|
38411
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1712 s_init, /* tp_init */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1713 PyType_GenericAlloc,/* tp_alloc */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1714 s_new, /* tp_new */ |
|
631b6648fdf4
enable all of the struct tests, use ssize_t, fix some whitespace
Bob Ippolito <bob@redivi.com>
parents:
38378
diff
changeset
|
1715 PyObject_Del, /* tp_free */ |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1716 }; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1717 |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1718 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1719 /* ---- Standalone functions ---- */ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1720 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1721 #define MAXCACHE 100 |
|
44459
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1722 static PyObject *cache = NULL; |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1723 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1724 static PyObject * |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1725 cache_struct(PyObject *fmt) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1726 { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1727 PyObject * s_object; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1728 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1729 if (cache == NULL) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1730 cache = PyDict_New(); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1731 if (cache == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1732 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1733 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1734 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1735 s_object = PyDict_GetItem(cache, fmt); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1736 if (s_object != NULL) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1737 Py_INCREF(s_object); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1738 return s_object; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1739 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1740 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1741 s_object = PyObject_CallFunctionObjArgs((PyObject *)(&PyStructType), fmt, NULL); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1742 if (s_object != NULL) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1743 if (PyDict_Size(cache) >= MAXCACHE) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1744 PyDict_Clear(cache); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1745 /* Attempt to cache the result */ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1746 if (PyDict_SetItem(cache, fmt, s_object) == -1) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1747 PyErr_Clear(); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1748 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1749 return s_object; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1750 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1751 |
|
44459
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1752 PyDoc_STRVAR(clearcache_doc, |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1753 "Clear the internal cache."); |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1754 |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1755 static PyObject * |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1756 clearcache(PyObject *self) |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1757 { |
|
44733
85cf220f16d8
clearcache() needs to remove the dict as well as clear it.
Raymond Hettinger <python@rcn.com>
parents:
44459
diff
changeset
|
1758 Py_CLEAR(cache); |
|
44459
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1759 Py_RETURN_NONE; |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1760 } |
|
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1761 |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1762 PyDoc_STRVAR(calcsize_doc, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1763 "Return size of C struct described by format string fmt."); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1764 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1765 static PyObject * |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1766 calcsize(PyObject *self, PyObject *fmt) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1767 { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1768 Py_ssize_t n; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1769 PyObject *s_object = cache_struct(fmt); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1770 if (s_object == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1771 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1772 n = ((PyStructObject *)s_object)->s_size; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1773 Py_DECREF(s_object); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1774 return PyInt_FromSsize_t(n); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1775 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1776 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1777 PyDoc_STRVAR(pack_doc, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1778 "Return string containing values v1, v2, ... packed according to fmt."); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1779 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1780 static PyObject * |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1781 pack(PyObject *self, PyObject *args) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1782 { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1783 PyObject *s_object, *fmt, *newargs, *result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1784 Py_ssize_t n = PyTuple_GET_SIZE(args); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1785 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1786 if (n == 0) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1787 PyErr_SetString(PyExc_TypeError, "missing format argument"); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1788 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1789 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1790 fmt = PyTuple_GET_ITEM(args, 0); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1791 newargs = PyTuple_GetSlice(args, 1, n); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1792 if (newargs == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1793 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1794 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1795 s_object = cache_struct(fmt); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1796 if (s_object == NULL) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1797 Py_DECREF(newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1798 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1799 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1800 result = s_pack(s_object, newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1801 Py_DECREF(newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1802 Py_DECREF(s_object); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1803 return result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1804 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1805 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1806 PyDoc_STRVAR(pack_into_doc, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1807 "Pack the values v1, v2, ... according to fmt.\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1808 Write the packed bytes into the writable buffer buf starting at offset."); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1809 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1810 static PyObject * |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1811 pack_into(PyObject *self, PyObject *args) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1812 { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1813 PyObject *s_object, *fmt, *newargs, *result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1814 Py_ssize_t n = PyTuple_GET_SIZE(args); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1815 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1816 if (n == 0) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1817 PyErr_SetString(PyExc_TypeError, "missing format argument"); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1818 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1819 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1820 fmt = PyTuple_GET_ITEM(args, 0); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1821 newargs = PyTuple_GetSlice(args, 1, n); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1822 if (newargs == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1823 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1824 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1825 s_object = cache_struct(fmt); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1826 if (s_object == NULL) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1827 Py_DECREF(newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1828 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1829 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1830 result = s_pack_into(s_object, newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1831 Py_DECREF(newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1832 Py_DECREF(s_object); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1833 return result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1834 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1835 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1836 PyDoc_STRVAR(unpack_doc, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1837 "Unpack the string containing packed C structure data, according to fmt.\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1838 Requires len(string) == calcsize(fmt)."); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1839 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1840 static PyObject * |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1841 unpack(PyObject *self, PyObject *args) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1842 { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1843 PyObject *s_object, *fmt, *inputstr, *result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1844 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1845 if (!PyArg_UnpackTuple(args, "unpack", 2, 2, &fmt, &inputstr)) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1846 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1847 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1848 s_object = cache_struct(fmt); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1849 if (s_object == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1850 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1851 result = s_unpack(s_object, inputstr); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1852 Py_DECREF(s_object); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1853 return result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1854 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1855 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1856 PyDoc_STRVAR(unpack_from_doc, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1857 "Unpack the buffer, containing packed C structure data, according to\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1858 fmt, starting at offset. Requires len(buffer[offset:]) >= calcsize(fmt)."); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1859 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1860 static PyObject * |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1861 unpack_from(PyObject *self, PyObject *args, PyObject *kwds) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1862 { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1863 PyObject *s_object, *fmt, *newargs, *result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1864 Py_ssize_t n = PyTuple_GET_SIZE(args); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1865 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1866 if (n == 0) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1867 PyErr_SetString(PyExc_TypeError, "missing format argument"); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1868 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1869 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1870 fmt = PyTuple_GET_ITEM(args, 0); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1871 newargs = PyTuple_GetSlice(args, 1, n); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1872 if (newargs == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1873 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1874 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1875 s_object = cache_struct(fmt); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1876 if (s_object == NULL) { |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1877 Py_DECREF(newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1878 return NULL; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1879 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1880 result = s_unpack_from(s_object, newargs, kwds); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1881 Py_DECREF(newargs); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1882 Py_DECREF(s_object); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1883 return result; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1884 } |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1885 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1886 static struct PyMethodDef module_functions[] = { |
|
44459
7643a43f25a1
Added _struct._clearcache() for regression tests
Christian Heimes <christian@cheimes.de>
parents:
44446
diff
changeset
|
1887 {"_clearcache", (PyCFunction)clearcache, METH_NOARGS, clearcache_doc}, |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1888 {"calcsize", calcsize, METH_O, calcsize_doc}, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1889 {"pack", pack, METH_VARARGS, pack_doc}, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1890 {"pack_into", pack_into, METH_VARARGS, pack_into_doc}, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1891 {"unpack", unpack, METH_VARARGS, unpack_doc}, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1892 {"unpack_from", (PyCFunction)unpack_from, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1893 METH_VARARGS|METH_KEYWORDS, unpack_from_doc}, |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1894 {NULL, NULL} /* sentinel */ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1895 }; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1896 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1897 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1898 /* Module initialization */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1899 |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1900 PyDoc_STRVAR(module_doc, |
|
56416
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1901 "Functions to convert between Python values and C structs represented\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1902 as Python strings. It uses format strings (explained below) as compact\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1903 descriptions of the lay-out of the C structs and the intended conversion\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1904 to/from Python values.\n\ |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1905 \n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1906 The optional first format char indicates byte order, size and alignment:\n\ |
|
56416
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1907 @: native order, size & alignment (default)\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1908 =: native order, std. size & alignment\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1909 <: little-endian, std. size & alignment\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1910 >: big-endian, std. size & alignment\n\ |
|
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1911 !: same as >\n\ |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1912 \n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1913 The remaining chars indicate types of args and must match exactly;\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1914 these can be preceded by a decimal repeat count:\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1915 x: pad byte (no data); c:char; b:signed byte; B:unsigned byte;\n\ |
|
56416
e759ca25701d
Issue #7078: _struct.__doc__ was being ignored. Import it into struct.
Mark Dickinson <dickinsm@gmail.com>
parents:
56246
diff
changeset
|
1916 ?: _Bool (requires C99; if not available, char is used instead)\n\ |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1917 h:short; H:unsigned short; i:int; I:unsigned int;\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1918 l:long; L:unsigned long; f:float; d:double.\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1919 Special cases (preceding decimal count indicates length):\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1920 s:string (array of char); p: pascal string (with count byte).\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1921 Special case (only available in native format):\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1922 P:an integer type that is wide enough to hold a pointer.\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1923 Special case (not in native mode unless 'long long' in platform C):\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1924 q:long long; Q:unsigned long long\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1925 Whitespace between formats is ignored.\n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1926 \n\ |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1927 The variable struct.error is an exception raised on errors.\n"); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1928 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1929 PyMODINIT_FUNC |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1930 init_struct(void) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1931 { |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1932 PyObject *ver, *m; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1933 |
|
47527
52294af4b663
This reverts r63675 based on the discussion in this thread:
Gregory P. Smith <greg@mad-scientist.com>
parents:
47294
diff
changeset
|
1934 ver = PyString_FromString("0.2"); |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1935 if (ver == NULL) |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1936 return; |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1937 |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
1938 m = Py_InitModule3("_struct", module_functions, module_doc); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1939 if (m == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1940 return; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1941 |
|
44350
26384b8180c7
#1629: Renamed Py_Size, Py_Type and Py_Refcnt to Py_SIZE, Py_TYPE and Py_REFCNT. Macros for b/w compatibility are available.
Christian Heimes <christian@cheimes.de>
parents:
42333
diff
changeset
|
1942 Py_TYPE(&PyStructType) = &PyType_Type; |
| 38312 | 1943 if (PyType_Ready(&PyStructType) < 0) |
| 1944 return; | |
| 1945 | |
|
55153
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1946 /* This speed trick can't be used until overflow masking goes |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1947 away, because native endian always raises exceptions |
|
b3fb5e6b7e82
Issue #1523: Remove deprecated overflow masking in struct module, and
Mark Dickinson <dickinsm@gmail.com>
parents:
55142
diff
changeset
|
1948 instead of overflow masking. */ |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1949 |
|
38317
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1950 /* Check endian and swap in faster functions */ |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1951 { |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1952 int one = 1; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1953 formatdef *native = native_table; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1954 formatdef *other, *ptr; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1955 if ((int)*(unsigned char*)&one) |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1956 other = lilendian_table; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1957 else |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1958 other = bigendian_table; |
|
38322
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1959 /* Scan through the native table, find a matching |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1960 entry in the endian table and swap in the |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1961 native implementations whenever possible |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1962 (64-bit platforms may not have "standard" sizes) */ |
|
38317
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1963 while (native->format != '\0' && other->format != '\0') { |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1964 ptr = other; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1965 while (ptr->format != '\0') { |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1966 if (ptr->format == native->format) { |
|
38322
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1967 /* Match faster when formats are |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1968 listed in the same order */ |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1969 if (ptr == other) |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1970 other++; |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1971 /* Only use the trick if the |
|
38322
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1972 size matches */ |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1973 if (ptr->size != native->size) |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1974 break; |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1975 /* Skip float and double, could be |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1976 "unknown" float format */ |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1977 if (ptr->format == 'd' || ptr->format == 'f') |
|
c77da2736fb2
fix test_float regression and 64-bit size mismatch issue
Bob Ippolito <bob@redivi.com>
parents:
38317
diff
changeset
|
1978 break; |
|
38317
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1979 ptr->pack = native->pack; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1980 ptr->unpack = native->unpack; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1981 break; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1982 } |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1983 ptr++; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1984 } |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1985 native++; |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1986 } |
|
68a348c9868d
Use faster struct pack/unpack functions for the endian table that matches the host's
Bob Ippolito <bob@redivi.com>
parents:
38316
diff
changeset
|
1987 } |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
1988 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1989 /* Add some symbolic constants to the module */ |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1990 if (StructError == NULL) { |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1991 StructError = PyErr_NewException("struct.error", NULL, NULL); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1992 if (StructError == NULL) |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1993 return; |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1994 } |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
1995 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1996 Py_INCREF(StructError); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1997 PyModule_AddObject(m, "error", StructError); |
|
38316
2f16e2715223
Use LONG_MIN and LONG_MAX to check Python integer bounds instead of the incorrect INT_MIN and INT_MAX
Bob Ippolito <bob@redivi.com>
parents:
38313
diff
changeset
|
1998 |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
1999 Py_INCREF((PyObject*)&PyStructType); |
|
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
2000 PyModule_AddObject(m, "Struct", (PyObject*)&PyStructType); |
|
38528
e0997ffa3572
Trimmed trailing whitespace.
Tim Peters <tim.peters@gmail.com>
parents:
38520
diff
changeset
|
2001 |
|
44446
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
2002 PyModule_AddObject(m, "__version__", ver); |
|
8d69edd3d290
Finish-up the struct module optimizations started at the Iceland NFS sprint.
Raymond Hettinger <python@rcn.com>
parents:
44350
diff
changeset
|
2003 |
|
38493
7d510e4f3c98
struct: modulo math plus warning on all endian-explicit formats for compatibility with older struct usage (ugly)
Bob Ippolito <bob@redivi.com>
parents:
38484
diff
changeset
|
2004 PyModule_AddIntConstant(m, "_PY_STRUCT_RANGE_CHECKING", 1); |
|
39380
9cb4565e60ca
Fix #1530559, struct.pack raises TypeError where it used to convert.
Bob Ippolito <bob@redivi.com>
parents:
39301
diff
changeset
|
2005 PyModule_AddIntConstant(m, "_PY_STRUCT_FLOAT_COERCE", 1); |
|
38259
895da42480f1
Patch #1493701: performance enhancements for struct module.
Bob Ippolito <bob@redivi.com>
parents:
diff
changeset
|
2006 } |
