Mercurial > cpython-lru_cache-weakref

changeset 63550:3068e00a3207 3.1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Merged revisions 83531 via svnmerge from svn+ssh://pythondev@svn.python.org/python/branches/py3k ........ r83531 | georg.brandl | 2010-08-02 19:24:49 +0200 (Mo, 02 Aug 2010) | 1 line #7372: fix regression in pstats: a previous fix to handle cProfile data in add_callers broke handling of profile data. ........
author Georg Brandl <georg@python.org>
date Mon, 02 Aug 2010 17:36:05 +0000
parents b08d35062088
children cecc6d2a5b49
files Lib/pstats.py Lib/test/test_pstats.py Misc/NEWS
diffstat 3 files changed, 16 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/Lib/pstats.py	Mon Aug 02 17:11:50 2010 +0000
+++ b/Lib/pstats.py	Mon Aug 02 17:36:05 2010 +0000
@@ -521,8 +521,13 @@
         new_callers[func] = caller
     for func, caller in source.items():
         if func in new_callers:
-            new_callers[func] = tuple([i[0] + i[1] for i in
-                                       zip(caller, new_callers[func])])
+            if isinstance(caller, tuple):
+                # format used by cProfile
+                new_callers[func] = tuple([i[0] + i[1] for i in
+                                           zip(caller, new_callers[func])])
+            else:
+                # format used by profile
+                new_callers[func] += caller
         else:
             new_callers[func] = caller
     return new_callers
--- a/Lib/test/test_pstats.py	Mon Aug 02 17:11:50 2010 +0000
+++ b/Lib/test/test_pstats.py	Mon Aug 02 17:36:05 2010 +0000
@@ -10,10 +10,16 @@
     def test_combine_results(self):
         """pstats.add_callers should combine the call results of both target
         and source by adding the call time. See issue1269."""
+        # new format: used by the cProfile module
         target = {"a": (1, 2, 3, 4)}
         source = {"a": (1, 2, 3, 4), "b": (5, 6, 7, 8)}
         new_callers = pstats.add_callers(target, source)
         self.assertEqual(new_callers, {'a': (2, 4, 6, 8), 'b': (5, 6, 7, 8)})
+        # old format: used by the profile module
+        target = {"a": 1}
+        source = {"a": 1, "b": 5}
+        new_callers = pstats.add_callers(target, source)
+        self.assertEqual(new_callers, {'a': 2, 'b': 5})
 
 
 def test_main():
--- a/Misc/NEWS	Mon Aug 02 17:11:50 2010 +0000
+++ b/Misc/NEWS	Mon Aug 02 17:36:05 2010 +0000
@@ -84,6 +84,9 @@
 Library
 -------
 
+- Issue #7372: Fix pstats regression when stripping paths from profile
+  data generated with the profile module.
+
 - Issue #4108: In urllib.robotparser, if there are multiple 'User-agent: *'
   entries, consider the first one.