Mercurial > cpython-lru_cache-weakref
changeset 17405:afbb65b60fa2 2.0
Inspired by Tim Peters' 1.14->1.15 checkin to asynchat
Quoting orignal message:
'''
Fix from the Madusa mailing list:
http://groups.yahoo.com/group/medusa/message/333
It's clear that Medusa should not be checking for an empty buffer
via "buf is ''". The patch merely changes "is" to "==". However,
there's a mystery here all the same: Python attempts to store null
strings uniquely, so it's unclear why "buf is ''" ever returned
false when buf actually was empty. *Some* string operations produce
non-unique null strings, e.g.
'''
| author | Moshe Zadka <moshez@math.huji.ac.il> |
|---|---|
| date | Wed, 11 Apr 2001 08:06:02 +0000 |
| parents | 01791a097456 |
| children | f7c12ba42737 |
| files | Lib/asynchat.py |
| diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/Lib/asynchat.py Wed Apr 11 08:01:24 2001 +0000 +++ b/Lib/asynchat.py Wed Apr 11 08:06:02 2001 +0000 @@ -166,7 +166,7 @@ # return len(self.ac_out_buffer) or len(self.producer_fifo) or (not self.connected) # this is about twice as fast, though not as clear. return not ( - (self.ac_out_buffer is '') and + (self.ac_out_buffer == '') and self.producer_fifo.is_empty() and self.connected )