changeset 84417:de44cd866bb0

Issue #18339: use with self.assertRaises() to make test case more readable
author Christian Heimes <christian@cheimes.de>
date Mon, 01 Jul 2013 23:00:22 +0200
parents 035577781505 (current diff) fa0a03afe359 (diff)
children ebe064e542ef
files
diffstat 1 files changed, 4 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/Lib/test/test_pickle.py	Mon Jul 01 19:10:39 2013 +0100
+++ b/Lib/test/test_pickle.py	Mon Jul 01 23:00:22 2013 +0200
@@ -117,9 +117,11 @@
 
         def test_issue18339(self):
             unpickler = self.unpickler_class(io.BytesIO())
-            self.assertRaises(TypeError, setattr, unpickler, "memo", object)
+            with self.assertRaises(TypeError):
+                unpickler.memo = object
             # used to cause a segfault
-            self.assertRaises(ValueError, setattr, unpickler, "memo", {-1: None})
+            with self.assertRaises(ValueError):
+                unpickler.memo = {-1: None}
             unpickler.memo = {1: None}
 
     class CDispatchTableTests(AbstractDispatchTableTests):